Skip to content

Commit 3aa29a0

Browse files
authored
Explicitly mentioning 'metrics' for the ACK controller service. (#77)
Description of changes: Explicitly mentioning 'metrics' for the ACK controller service. Sample dry-run putput: ``` # Source: ack-apigatewayv2-controller/templates/metrics-service.yaml apiVersion: v1 kind: Service metadata: name: somename-ack-apigatewayv2-controller-metrics namespace: default labels: app.kubernetes.io/name: ack-apigatewayv2-controller app.kubernetes.io/instance: somename app.kubernetes.io/managed-by: Helm app.kubernetes.io/version: "v0.0.2" k8s-app: ack-apigatewayv2-controller helm.sh/chart: ack-apigatewayv2-controller-v0.0.2 control-plane: controller spec: selector: app.kubernetes.io/name: ack-apigatewayv2-controller app.kubernetes.io/instance: somename app.kubernetes.io/managed-by: Helm k8s-app: ack-apigatewayv2-controller type: ClusterIP ports: - name: metricsport port: 8080 targetPort: 8080 protocol: TCP ``` By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
1 parent 90fbdaa commit 3aa29a0

File tree

2 files changed

+11
-6
lines changed

2 files changed

+11
-6
lines changed

templates/helm/templates/service.yaml renamed to templates/helm/templates/metrics-service.yaml

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
{{- if .Values.service.create }}
1+
{{- if .Values.metrics.service.create }}
22
apiVersion: v1
33
kind: Service
44
metadata:
5-
name: {{ include "app.fullname" . }}
5+
name: {{ include "app.fullname" . }}-metrics
66
namespace: {{ .Release.Namespace }}
77
labels:
88
app.kubernetes.io/name: {{ include "app.name" . }}
@@ -21,7 +21,7 @@ spec:
2121
{{- range $key, $value := .Values.deployment.labels }}
2222
{{ $key }}: {{ $value | quote }}
2323
{{- end }}
24-
type: {{ .Values.service.type }}
24+
type: {{ .Values.metrics.service.type }}
2525
ports:
2626
- name: metricsport
2727
port: 8080

templates/helm/values.yaml.tpl

+8-3
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,14 @@ deployment:
1616
labels: {}
1717
containerPort: 8080
1818

19-
service:
20-
create: false
21-
type: "ClusterIP"
19+
metrics:
20+
service:
21+
# Set to true to automatically create a Kubernetes Service resource for the
22+
# Prometheus metrics server endpoint in controller
23+
create: false
24+
# Which Type to use for the Kubernetes Service?
25+
# See: https://kubernetes.io/docs/concepts/services-networking/service/#publishing-services-service-types
26+
type: "ClusterIP"
2227

2328
resources:
2429
requests:

0 commit comments

Comments
 (0)