Commit 0916df1
authored
return nil if observed is nil from a successful delete (#182)
Issue #, if available:
aws-controllers-k8s/community#931
Description of changes:
Solution 2 in the issue linked above. If `rm.Delete` does not return an error, and observed is also nil, return `nil, nil` to the caller instead of the resource passed to the method.
Testing:
`make test`
Manually using sagemaker controller
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.1 parent a866a84 commit 0916df1
1 file changed
+7
-4
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
154 | 154 | | |
155 | 155 | | |
156 | 156 | | |
157 | | - | |
158 | | - | |
159 | | - | |
160 | | - | |
| 157 | + | |
161 | 158 | | |
162 | 159 | | |
163 | 160 | | |
| |||
266 | 263 | | |
267 | 264 | | |
268 | 265 | | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
269 | 269 | | |
270 | 270 | | |
271 | 271 | | |
| |||
286 | 286 | | |
287 | 287 | | |
288 | 288 | | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
289 | 292 | | |
290 | 293 | | |
291 | 294 | | |
| |||
0 commit comments