Skip to content

Commit 2af01f5

Browse files
authored
Ignore DomainValidationOptions and keyAlgorithm deltaCompare (#57)
Issue [#2395](aws-controllers-k8s/community#2395) Description of changes: The DomainValidationOptions are returned with arbitrary order. Removing comparison completely since there is no update operation to change it. Same goes for keyAlgorithm By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
1 parent 63cd265 commit 2af01f5

File tree

7 files changed

+31
-17
lines changed

7 files changed

+31
-17
lines changed
Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
ack_generate_info:
2-
build_date: "2025-03-27T16:36:43Z"
2+
build_date: "2025-04-03T18:41:21Z"
33
build_hash: 980cb1e4734f673d16101cf55206b84ca639ec01
44
go_version: go1.24.1
55
version: v0.44.0
6-
api_directory_checksum: 06c3fd0ed69ec69d489b2ca1582a2b21caaf2ad5
6+
api_directory_checksum: c81e9094002706a6f7db72617aa0348cb7e53dd5
77
api_version: v1alpha1
88
aws_sdk_go_version: v1.32.6
99
generator_config_info:
10-
file_checksum: 38b3144fc024675b7bdccb9141fc36779effb946
10+
file_checksum: 1489a54e7f1a1b28f8b44e738c239b03b364f74a
1111
original_file_name: generator.yaml
1212
last_modification:
1313
reason: API generation

apis/v1alpha1/certificate.go

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

apis/v1alpha1/generator.yaml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,9 @@ resources:
8585
is_immutable: true
8686
KeyAlgorithm:
8787
late_initialize: {}
88+
is_immutable: true
89+
compare:
90+
is_ignored: true
8891
Options:
8992
late_initialize: {}
9093
# NOTE(jaypipes): The Create operation (RequestCertificate) has a
@@ -102,6 +105,10 @@ resources:
102105
from:
103106
operation: DescribeCertificate
104107
path: Certificate.DomainValidationOptions
108+
DomainValidationOptions:
109+
is_immutable: true
110+
compare:
111+
is_ignored: true
105112
ExtendedKeyUsages:
106113
is_read_only: true
107114
from:

config/crd/bases/acm.services.k8s.aws_certificates.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -152,6 +152,9 @@ spec:
152152
type: string
153153
type: object
154154
type: array
155+
x-kubernetes-validations:
156+
- message: Value is immutable once set
157+
rule: self == oldSelf
155158
keyAlgorithm:
156159
description: |-
157160
Specifies the algorithm of the public and private key pair that your certificate
@@ -181,6 +184,9 @@ spec:
181184
182185
Default: RSA_2048
183186
type: string
187+
x-kubernetes-validations:
188+
- message: Value is immutable once set
189+
rule: self == oldSelf
184190
options:
185191
description: |-
186192
Currently, you can use this parameter to specify whether to add the certificate

generator.yaml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,9 @@ resources:
8585
is_immutable: true
8686
KeyAlgorithm:
8787
late_initialize: {}
88+
is_immutable: true
89+
compare:
90+
is_ignored: true
8891
Options:
8992
late_initialize: {}
9093
# NOTE(jaypipes): The Create operation (RequestCertificate) has a
@@ -102,6 +105,10 @@ resources:
102105
from:
103106
operation: DescribeCertificate
104107
path: Certificate.DomainValidationOptions
108+
DomainValidationOptions:
109+
is_immutable: true
110+
compare:
111+
is_ignored: true
105112
ExtendedKeyUsages:
106113
is_read_only: true
107114
from:

helm/crds/acm.services.k8s.aws_certificates.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -152,6 +152,9 @@ spec:
152152
type: string
153153
type: object
154154
type: array
155+
x-kubernetes-validations:
156+
- message: Value is immutable once set
157+
rule: self == oldSelf
155158
keyAlgorithm:
156159
description: |-
157160
Specifies the algorithm of the public and private key pair that your certificate
@@ -181,6 +184,9 @@ spec:
181184
182185
Default: RSA_2048
183186
type: string
187+
x-kubernetes-validations:
188+
- message: Value is immutable once set
189+
rule: self == oldSelf
184190
options:
185191
description: |-
186192
Currently, you can use this parameter to specify whether to add the certificate

pkg/resource/certificate/delta.go

Lines changed: 0 additions & 14 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)