Pre-commit hook for linting, testing

Author: tobywf

.coveragerc

@@ -0,0 +1,6 @@
+[run]
+branch = True
+omit = */contract/suite/*
+
+[report]
+fail_under = 99

.pre-commit-config.yaml

@@ -0,0 +1,66 @@
+exclude: ^(buildspec.yml|.pre-commit-config.yaml)$
+repos:
+- repo: https://github.com/pre-commit/pre-commit-hooks
+  rev: v2.0.0
+  hooks:
+  - id: check-case-conflict
+  - id: end-of-file-fixer
+  - id: mixed-line-ending
+    args:
+    - --fix=lf
+  - id: trailing-whitespace
+  - id: flake8
+    additional_dependencies:
+    - flake8-bugbear>=19.3.0
+    - flake8-builtins>=1.4.1
+    - flake8-commas>=2.0.0
+    - flake8-comprehensions>=2.1.0
+    - flake8-debugger>=3.1.0
+    - flake8-pep3101>=1.2.1
+    # language_version: python3.6
+  - id: pretty-format-json
+    args:
+    - --autofix
+    - --indent=4
+    - --no-sort-keys
+  - id: check-merge-conflict
+  - id: check-yaml
+- repo: https://github.com/pre-commit/mirrors-isort
+  rev: v4.3.17
+  hooks:
+  - id: isort
+    # language_version: python3.6
+- repo: https://github.com/ambv/black
+  rev: stable
+  hooks:
+  - id: black
+    # language_version: python3.6
+- repo: https://github.com/pre-commit/pygrep-hooks
+  rev: v1.3.0
+  hooks:
+  - id: python-check-blanket-noqa
+  - id: python-check-mock-methods
+  - id: python-no-log-warn
+- repo: https://github.com/PyCQA/bandit
+  rev: f5a6f0ca62  # TODO: update once a release > 1.5.1 hits with this change in
+  hooks:
+  - id: bandit
+    files: "^python/"
+- repo: local
+  hooks:
+  - id: pylint-local
+    name: pylint-local
+    description: Run pylint in the local virtualenv
+    entry: pylint "setup.py" "python/" "tests/"
+    language: system
+    # ignore all files, run on hard-coded modules instead
+    exclude: "^."
+    always_run: true
+  - id: pytest-local
+    name: pytest-local
+    description: Run pytest in the local virtualenv
+    entry: pytest --cov=rpdk.java --doctest-modules tests/
+    language: system
+    # ignore all files, run on hard-coded modules instead
+    exclude: "^."
+    always_run: true

.pylintrc

@@ -0,0 +1,24 @@
+[MASTER]
+
+ignore=CVS
+jobs=1
+persistent=yes
+
+[MESSAGES CONTROL]
+
+disable=
+    missing-docstring,          # not everything needs a docstring
+    fixme,                      # work in progress
+    bad-continuation,           # clashes with black
+    duplicate-code,             # finds dupes between tests and plugins
+    too-few-public-methods,     # triggers when inheriting
+    ungrouped-imports,          # clashes with isort
+
+[BASIC]
+
+good-names=e,ex,f,fp,i,j,k,n,_
+
+[FORMAT]
+
+indent-string='    '
+max-line-length=88

buildspec.yml

@@ -3,10 +3,11 @@ phases:
   install:
     commands:
       # make sure pip/setuptools/wheel is up to date
-      - pip install --upgrade pip setuptools wheel
+      - pip install --upgrade pip setuptools wheel -r requirements.txt
       - mkdir "$CODEBUILD_SRC_DIR/artifacts"
   build:
     commands:
+      - pre-commit run --all-files
       # install aws-cloudformation-rpdk
       - cd "$CODEBUILD_SRC_DIR_RPDK"
       - python3 setup.py sdist bdist_wheel

requirements.txt

@@ -0,0 +1,13 @@
+# better interactive session, debugger
+ipython>=7.4.0
+ipdb>=0.12
+
+# testing tools
+pylint>=2.3.1
+coverage>=4.5.3
+pytest>=4.4.0
+pytest-cov>=2.6.1
+pytest-random-order>=1.0.4
+
+# commit hooks
+pre-commit>=1.15.2

setup.cfg

@@ -29,6 +29,7 @@ include_trailing_comma = true
 combine_as_imports = True
 force_grid_wrap = 0
 known_first_party = rpdk
+known_third_party = boto3,botocore,jinja2,jsonschema,werkzeug,yaml,requests
 
 [tool:pytest]
 # can't do anything about 3rd party modules, so don't spam us