Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Update footer text #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −1
Open

✨ Update footer text #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/footer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ export function Footer({ children }) {
</div>
</div>
<div className={css.copyright}>
<p>&copy; ab506.church {CURRENT_YEAR}</p>
<p>&copy; Awe and Reverence {CURRENT_YEAR}</p>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a constant. You can put the constant in constants/seo.py

Names can be consider for constant:

  • PARENT_SITE_NAME
  • GROUP_SITE_NAME
  • AR_SITE_NAME

Maybe it is best that @jontsai decide the name.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hardcoded is fine for now.

Realistically, we may want to create a 3rd GitHub repository as a submodule to store the constants.

Or, we might create a public NPMJS package hosted in our GitHub repository (such as aweandreverence-nextjs-common. @goztrk thoughts?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, done

</div>
</footer>
</>
Expand Down