✨ Update footer text #2
Conversation
| @@ -37,7 +37,7 @@ export function Footer({ children }) { | |||
| </div> | |||
| </div> | |||
| <div className={css.copyright}> | |||
| <p>© ab506.church {CURRENT_YEAR}</p> | |||
| <p>© Awe and Reverence {CURRENT_YEAR}</p> | |||
There was a problem hiding this comment.
This should be a constant. You can put the constant in constants/seo.py
Names can be consider for constant:
- PARENT_SITE_NAME
- GROUP_SITE_NAME
- AR_SITE_NAME
Maybe it is best that @jontsai decide the name.
There was a problem hiding this comment.
Hardcoded is fine for now.
Realistically, we may want to create a 3rd GitHub repository as a submodule to store the constants.
Or, we might create a public NPMJS package hosted in our GitHub repository (such as aweandreverence-nextjs-common. @goztrk thoughts?
| @@ -37,7 +37,7 @@ export function Footer({ children }) { | |||
| </div> | |||
| </div> | |||
| <div className={css.copyright}> | |||
| <p>© ab506.church {CURRENT_YEAR}</p> | |||
| <p>© Awe and Reverence {CURRENT_YEAR}</p> | |||
There was a problem hiding this comment.
Hardcoded is fine for now.
Realistically, we may want to create a 3rd GitHub repository as a submodule to store the constants.
Or, we might create a public NPMJS package hosted in our GitHub repository (such as aweandreverence-nextjs-common. @goztrk thoughts?
Pinimes
force-pushed
the
features/update-footer-text
branch
from
cd5af9d to
42e6a9f
Compare
Status
Ready
Description
Screenshot