1. Fixed TODO

Author: maranqz

gorm/README.md

@@ -0,0 +1,2 @@
+Implementation rewrites [DisableNestedTransaction](https://gorm.io/docs/gorm_config.html#DisableNestedTransaction) by [Settings.Propogation](../trm/settings.go) if it is [PropagationNested](../trm/transaction.go).
+

gorm/factory.go

@@ -16,8 +16,7 @@ func NewDefaultFactory(db *gorm.DB) trm.TrFactory {
 	return func(ctx context.Context, trms trm.Settings) (context.Context, trm.Transaction, error) {
 		s, _ := trms.(Settings)
 
-		// TODO do update TRM config by settings gorm nested transaction
-		// db.DisableNestedTransaction = true
+		db.Config.DisableNestedTransaction = trms.Propagation() != trm.PropagationNested
 
 		return NewTransaction(ctx, s.TxOpts(), db)
 	}

redis/settings.go

@@ -160,6 +160,10 @@ func (s *Settings) Return() []redis.Cmder {
 
 // AppendReturn append []redis.Cmder from Transaction.
 func (s *Settings) AppendReturn(cmds ...redis.Cmder) {
+	if s.ReturnPtr() == nil {
+		return
+	}
+
 	s.muRet.Lock()
 	defer s.muRet.Unlock()
 

redis/transaction.go

@@ -60,7 +60,7 @@ func NewTransaction(
 				return t.isClosedClosure.Err()
 			})
 
-			if len(cmds) > 0 && s.ReturnPtr() != nil {
+			if len(cmds) > 0 {
 				s.AppendReturn(cmds...)
 			}
 
@@ -108,10 +108,7 @@ func (t *Transaction) Transaction() interface{} {
 func (t *Transaction) Commit(ctx context.Context) error {
 	select {
 	case <-t.isClosed.Closed():
-		cmds, err := t.tx.Exec(ctx)
-
-		// TODO process cmds
-		_ = cmds
+		_, err := t.tx.Exec(ctx)
 
 		return err
 	default: