Skip to content

Commit fb3a170

Browse files
committed
SideBar: Add ViewAction and ViewRemote objects
These two new classes can represent items in our SourceList that refer to specific actions (such as comitting), or specific Remotes.
1 parent c59d68b commit fb3a170

7 files changed

+87
-9
lines changed

GitX.xcodeproj/project.pbxproj

+12
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,8 @@
5252
F513085B0E0740F2000C8BCD /* PBQLOutlineView.m in Sources */ = {isa = PBXBuildFile; fileRef = F513085A0E0740F2000C8BCD /* PBQLOutlineView.m */; };
5353
F5140DC90E8A8EB20091E9F3 /* RoundedRectangle.m in Sources */ = {isa = PBXBuildFile; fileRef = F5140DC80E8A8EB20091E9F3 /* RoundedRectangle.m */; };
5454
F523CEB60ED3399200DDD714 /* PBGitIndexController.m in Sources */ = {isa = PBXBuildFile; fileRef = F523CEB50ED3399200DDD714 /* PBGitIndexController.m */; };
55+
F528210A1056A7C1001D1511 /* PBSourceViewRemote.m in Sources */ = {isa = PBXBuildFile; fileRef = F52821091056A7C1001D1511 /* PBSourceViewRemote.m */; };
56+
F528210D1056A7EB001D1511 /* PBSourceViewAction.m in Sources */ = {isa = PBXBuildFile; fileRef = F528210C1056A7EB001D1511 /* PBSourceViewAction.m */; };
5557
F52BCE030E84208300AA3741 /* PBGitHistoryView.xib in Resources */ = {isa = PBXBuildFile; fileRef = F52BCE020E84208300AA3741 /* PBGitHistoryView.xib */; };
5658
F52BCE070E84211300AA3741 /* PBGitHistoryController.m in Sources */ = {isa = PBXBuildFile; fileRef = F52BCE060E84211300AA3741 /* PBGitHistoryController.m */; };
5759
F53C4DF70E97FC630022AD59 /* PBGitBinary.m in Sources */ = {isa = PBXBuildFile; fileRef = F53C4DF60E97FC630022AD59 /* PBGitBinary.m */; };
@@ -213,6 +215,10 @@
213215
F5140DC80E8A8EB20091E9F3 /* RoundedRectangle.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = RoundedRectangle.m; sourceTree = "<group>"; };
214216
F523CEB40ED3399100DDD714 /* PBGitIndexController.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = PBGitIndexController.h; sourceTree = "<group>"; };
215217
F523CEB50ED3399200DDD714 /* PBGitIndexController.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = PBGitIndexController.m; sourceTree = "<group>"; };
218+
F52821081056A7C1001D1511 /* PBSourceViewRemote.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = PBSourceViewRemote.h; sourceTree = "<group>"; };
219+
F52821091056A7C1001D1511 /* PBSourceViewRemote.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = PBSourceViewRemote.m; sourceTree = "<group>"; };
220+
F528210B1056A7EB001D1511 /* PBSourceViewAction.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = PBSourceViewAction.h; sourceTree = "<group>"; };
221+
F528210C1056A7EB001D1511 /* PBSourceViewAction.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = PBSourceViewAction.m; sourceTree = "<group>"; };
216222
F52BCE020E84208300AA3741 /* PBGitHistoryView.xib */ = {isa = PBXFileReference; lastKnownFileType = file.xib; path = PBGitHistoryView.xib; sourceTree = "<group>"; };
217223
F52BCE050E84211300AA3741 /* PBGitHistoryController.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = PBGitHistoryController.h; sourceTree = "<group>"; };
218224
F52BCE060E84211300AA3741 /* PBGitHistoryController.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = PBGitHistoryController.m; sourceTree = "<group>"; };
@@ -583,6 +589,10 @@
583589
F58DB55810566D3500CFDF4A /* PBGitSidebarController.m */,
584590
F58DB5E6105671B600CFDF4A /* PBSourceViewItem.h */,
585591
F58DB5E7105671B600CFDF4A /* PBSourceViewItem.m */,
592+
F52821081056A7C1001D1511 /* PBSourceViewRemote.h */,
593+
F52821091056A7C1001D1511 /* PBSourceViewRemote.m */,
594+
F528210B1056A7EB001D1511 /* PBSourceViewAction.h */,
595+
F528210C1056A7EB001D1511 /* PBSourceViewAction.m */,
586596
);
587597
name = Sidebar;
588598
sourceTree = "<group>";
@@ -900,6 +910,8 @@
900910
F58DB55910566D3500CFDF4A /* PBGitSidebarController.m in Sources */,
901911
F58DB5E8105671B600CFDF4A /* PBSourceViewItem.m in Sources */,
902912
F567B88D1057FA9F000DB976 /* NSOutlineViewExt.m in Sources */,
913+
F528210A1056A7C1001D1511 /* PBSourceViewRemote.m in Sources */,
914+
F528210D1056A7EB001D1511 /* PBSourceViewAction.m in Sources */,
903915
);
904916
runOnlyForDeploymentPostprocessing = 0;
905917
};

PBSourceViewAction.h

+17
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
//
2+
// PBSourceViewAction.h
3+
// GitX
4+
//
5+
// Created by Pieter de Bie on 9/8/09.
6+
// Copyright 2009 __MyCompanyName__. All rights reserved.
7+
//
8+
9+
#import <Cocoa/Cocoa.h>
10+
#import "PBSourceViewItem.h"
11+
12+
@interface PBSourceViewAction : PBSourceViewItem {
13+
NSImage *icon;
14+
}
15+
16+
@property(retain) NSImage *icon;
17+
@end

PBSourceViewAction.m

+15
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
//
2+
// PBSourceViewAction.m
3+
// GitX
4+
//
5+
// Created by Pieter de Bie on 9/8/09.
6+
// Copyright 2009 __MyCompanyName__. All rights reserved.
7+
//
8+
9+
#import "PBSourceViewAction.h"
10+
11+
12+
@implementation PBSourceViewAction
13+
@synthesize icon;
14+
15+
@end

PBSourceViewItem.h

+3-3
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,9 @@
2020
BOOL isGroupItem;
2121
}
2222

23-
+ (PBSourceViewItem *)groupItemWithTitle:(NSString *)title;
24-
+ (PBSourceViewItem *)itemWithRevSpec:(PBGitRevSpecifier *)revSpecifier;
25-
+ (PBSourceViewItem *)itemWithTitle:(NSString *)title;
23+
+ (id)groupItemWithTitle:(NSString *)title;
24+
+ (id)itemWithRevSpec:(PBGitRevSpecifier *)revSpecifier;
25+
+ (id)itemWithTitle:(NSString *)title;
2626

2727
- (void)addChild:(PBSourceViewItem *)child;
2828

PBSourceViewItem.m

+6-6
Original file line numberDiff line numberDiff line change
@@ -21,25 +21,25 @@ - (id)init
2121
return self;
2222
}
2323

24-
+ (PBSourceViewItem *)groupItemWithTitle:(NSString *)title
24+
+ (id)groupItemWithTitle:(NSString *)title
2525
{
26-
PBSourceViewItem *item = [[PBSourceViewItem alloc] init];
26+
PBSourceViewItem *item = [[[self class] alloc] init];
2727
item.title = title;
2828
item.isGroupItem = YES;
2929
return item;
3030
}
3131

32-
+ (PBSourceViewItem *)itemWithRevSpec:(PBGitRevSpecifier *)revSpecifier
32+
+ (id)itemWithRevSpec:(PBGitRevSpecifier *)revSpecifier
3333
{
34-
PBSourceViewItem *item = [[PBSourceViewItem alloc] init];
34+
PBSourceViewItem *item = [[[self class] alloc] init];
3535
item.revSpecifier = revSpecifier;
3636

3737
return item;
3838
}
3939

40-
+ (PBSourceViewItem *)itemWithTitle:(NSString *)title;
40+
+ (id)itemWithTitle:(NSString *)title;
4141
{
42-
PBSourceViewItem *item = [[PBSourceViewItem alloc] init];
42+
PBSourceViewItem *item = [[[self class] alloc] init];
4343
item.title = title;
4444
return item;
4545
}

PBSourceViewRemote.h

+16
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
//
2+
// PBSourceViewRemote.h
3+
// GitX
4+
//
5+
// Created by Pieter de Bie on 9/8/09.
6+
// Copyright 2009 __MyCompanyName__. All rights reserved.
7+
//
8+
9+
#import <Cocoa/Cocoa.h>
10+
#import "PBSourceViewItem.h"
11+
12+
@interface PBSourceViewRemote : PBSourceViewItem {
13+
14+
}
15+
16+
@end

PBSourceViewRemote.m

+18
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
//
2+
// PBSourceViewRemote.m
3+
// GitX
4+
//
5+
// Created by Pieter de Bie on 9/8/09.
6+
// Copyright 2009 __MyCompanyName__. All rights reserved.
7+
//
8+
9+
#import "PBSourceViewRemote.h"
10+
11+
12+
@implementation PBSourceViewRemote
13+
14+
- (NSImage *)icon
15+
{
16+
return [NSImage imageNamed:@"remote"];
17+
}
18+
@end

0 commit comments

Comments
 (0)