Bugfix: crasher on 10.5 due to webkit and the <button> element

brotherbard · brotherbard · commit 9a9de9577c6a · 2010-09-18T19:17:12.000-06:00
Something in webkit doesn't like the button html element nor the -webkit-appearance: button css tag. Ends up crashing in one of various WebCore::ThemeMac::paint functions.

This would crash for anyone on 10.5 with the Gist it button enabled (which it is by default so that means anyone who ran it for the first time).

Changing the button back to the way it was before SHA:b557d6b5c6e675216d340d20833f39d0096b7ccc
diff --git a/html/views/history/history.css b/html/views/history/history.css
@@ -26,12 +26,21 @@ body {
 	float: left;
 }
 
-#gist {
-	-webkit-appearance: button;
-	font: 13px bold 'Lucida Grande';
-	width: 80px;
-	height: 23px;
-	margin-right: 5px;
+a.servicebutton {
+    display: block;
+    width: 80px;
+    padding: 2px;
+    margin-bottom: 4px;
+
+    border: 1px solid #3465a4;
+    background-color: #cce5ff;
+    color: #204a87;
+
+    font-size: 65%;
+    text-decoration: none;
+    text-align: center;
+
+    -webkit-border-radius: 2px;
 }
 
 .gravatar {
diff --git a/html/views/history/index.html b/html/views/history/index.html
@@ -14,7 +14,9 @@
 <body style="padding: 0px; border: 0px">
 	<div id="rightcontent">
 		<div id="buttons">
-			<button id="gist" onClick="confirm_gist();return false" style="display:none">Gist&nbsp;it</button>
+			<a class="servicebutton" id="gist" onclick="confirm_gist();return false" href="#">
+            	Gist it
+        	</a>
 		</div>
 	</div>
 	<table id="commit_header">
