Skip to content

Commit 526f246

Browse files
committed
correct branch ahead/behind counters
1 parent b4d2b0d commit 526f246

File tree

2 files changed

+13
-7
lines changed

2 files changed

+13
-7
lines changed

PBGitRepository.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ static NSString * PBStringFromBranchFilterType(PBGitXBranchFilterType type) {
129129
- (void)findInModeScriptCommand:(NSScriptCommand *)command;
130130

131131
-(NSNumber *)countCommintsOf:(NSString *)branchs;
132-
+(bool)isLocalBranch:(NSString *)name;
132+
+(bool)isLocalBranch:(NSString *)branch branchNameInto:(NSString **)name;
133133

134134

135135
@property (assign) BOOL hasChanged;

PBGitRepository.m

+12-6
Original file line numberDiff line numberDiff line change
@@ -269,9 +269,10 @@ - (void) reloadRefs
269269
PBGitRef *newRef = [PBGitRef refFromString:[components objectAtIndex:0]];
270270
PBGitRevSpecifier *revSpec = [[PBGitRevSpecifier alloc] initWithRef:newRef];
271271

272-
if([PBGitRepository isLocalBranch:[components objectAtIndex:0]]){
273-
[revSpec setAhead:[self countCommintsOf:[NSString stringWithFormat:@"origin..%@",[components objectAtIndex:0]]]];
274-
[revSpec setBehind:[self countCommintsOf:[NSString stringWithFormat:@"%@..origin",[components objectAtIndex:0]]]];
272+
NSString *bName;
273+
if([PBGitRepository isLocalBranch:[components objectAtIndex:0] branchNameInto:&bName]){
274+
[revSpec setAhead:[self countCommintsOf:[NSString stringWithFormat:@"origin/%@..%@",bName,bName]]];
275+
[revSpec setBehind:[self countCommintsOf:[NSString stringWithFormat:@"%@..origin/%@",bName,bName]]];
275276
}
276277
[self addBranch:revSpec];
277278
[self addRef:newRef fromParameters:components];
@@ -288,14 +289,19 @@ - (void) reloadRefs
288289
[[[self windowController] window] setTitle:[self displayName]];
289290
}
290291

291-
+(bool)isLocalBranch:(NSString *)name
292+
+(bool)isLocalBranch:(NSString *)branch branchNameInto:(NSString **)name
292293
{
293-
NSScanner *scanner=[NSScanner scannerWithString:name];
294-
return [scanner scanString:@"refs/heads/" intoString:NULL];
294+
NSScanner *scanner=[NSScanner scannerWithString:branch];
295+
bool is=[scanner scanString:@"refs/heads/" intoString:NULL];
296+
if(is && (name)){
297+
*name=[branch substringFromIndex:[scanner scanLocation]];
298+
}
299+
return is;
295300
}
296301

297302
-(NSNumber *)countCommintsOf:(NSString *)branchs
298303
{
304+
NSLog(@"branchs:'%@'",branchs);
299305
NSArray *args = [NSArray arrayWithObjects:@"rev-list", branchs, nil];
300306
NSString *o = [self outputForArguments:args];
301307
if ([o length]==0) {

0 commit comments

Comments
 (0)