fixes

Author: szmarczak

index.js

@@ -24,12 +24,12 @@ function isValidRewritePaths(rewritePaths) {
 	});
 }
 
-function isValidPrecompile(precompile) {
-	return typeof precompile === 'boolean' || precompile === undefined;
+function isValidCompile(compile) {
+	return typeof compile === 'boolean' || compile === undefined;
 }
 
 async function compileTypeScript(projectDir) {
-	return execa.command(`npx tsc --build ${projectDir}/../tsconfig.json`);
+	return execa('tsc', ['--build', path.resolve(projectDir, 'tsconfig.json')], {preferLocal: true, cwd: projectDir});
 }
 
 module.exports = ({negotiateProtocol}) => {
@@ -43,11 +43,11 @@ module.exports = ({negotiateProtocol}) => {
 			let valid = false;
 			if (isPlainObject(config)) {
 				const keys = Object.keys(config);
-				if (keys.every(key => key === 'extensions' || key === 'rewritePaths' || key === 'precompile')) {
+				if (keys.every(key => key === 'extensions' || key === 'rewritePaths' || key === 'compile')) {
 					valid =
 						(config.extensions === undefined || isValidExtensions(config.extensions)) &&
 						isValidRewritePaths(config.rewritePaths) &&
-						isValidPrecompile(config.precompile);
+						isValidCompile(config.compile);
 				}
 			}
 
@@ -58,7 +58,7 @@ module.exports = ({negotiateProtocol}) => {
 			const {
 				extensions = ['ts'],
 				rewritePaths: relativeRewritePaths,
-				precompile = true
+				compile: relativeCompile = true
 			} = config;
 
 			const rewritePaths = Object.entries(relativeRewritePaths).map(([from, to]) => [
@@ -69,14 +69,14 @@ module.exports = ({negotiateProtocol}) => {
 
 			return {
 				async compile() {
-					if (precompile) {
+					if (relativeCompile) {
 						await compileTypeScript(protocol.projectDir);
 					}
 
 					return {
 						extensions: extensions.slice(),
 						rewritePaths: rewritePaths.slice(),
-						precompile
+						compile: Boolean(relativeCompile)
 					};
 				},
 

package.json

@@ -16,7 +16,7 @@
     "typescript"
   ],
   "scripts": {
-    "test": "xo && nyc ava"
+    "test": "del-cli test/fixtures/compiled && xo && nyc ava"
   },
   "dependencies": {
     "escape-string-regexp": "^2.0.0",
@@ -25,6 +25,7 @@
   },
   "devDependencies": {
     "ava": "^3.0.0",
+    "del-cli": "^3.0.0",
     "nyc": "^15.0.0",
     "typescript": "^3.7.5",
     "xo": "^0.25.3"

test/fixtures/compiled/typescript.js

@@ -0,0 +1 @@
+console.log('logged in typescript.ts');

test/protocol-ava-3.js

@@ -55,6 +55,10 @@ test('main() config validation: config may not be an empty object', withProvider
 	validateConfig(t, provider, {});
 });
 
+test('main() config validation: throw when config.compile is not a boolean nor undefined', withProvider, (t, provider) => {
+	validateConfig(t, provider, {rewritePaths: {'src/': 'build/'}, compile: 1});
+});
+
 test('main() config validation: rewrite paths must end in a /', withProvider, (t, provider) => {
 	validateConfig(t, provider, {rewritePaths: {src: 'build/'}});
 	validateConfig(t, provider, {rewritePaths: {'src/': 'build'}});
@@ -101,7 +105,7 @@ test('worker(): load rewritten paths files', withProvider, async (t, provider) =
 	t.snapshot(stdout);
 });
 
-test('worker(): runs precompiled files', withProvider, async (t, provider) => {
+test('worker(): runs compiled files', withProvider, async (t, provider) => {
 	const {state} = await compile(provider);
 	const {stdout, stderr} = await execa.node(
 		path.join(__dirname, 'fixtures/install-and-load'),

test/snapshots/protocol-ava-3.js.md

@@ -60,6 +60,14 @@ Generated by [AVA](https://avajs.dev).
       message: 'Unexpected Typescript configuration for AVA. See https://github.com/avajs/typescript/blob/v${pkg.version}/README.md for allowed values.',
     }
 
+## main() config validation: throw when config.compile is not a boolean nor undefined
+
+> Snapshot 1
+
+    Error {
+      message: 'Unexpected Typescript configuration for AVA. See https://github.com/avajs/typescript/blob/v${pkg.version}/README.md for allowed values.',
+    }
+
 ## main() config validation: throw when config.extensions contains duplicates
 
 > Snapshot 1
@@ -90,8 +98,8 @@ Generated by [AVA](https://avajs.dev).
 
     'logged in file.js'
 
-## worker(): runs precompiled files
+## worker(): runs compiled files
 
 > Snapshot 1
 
-    ''
+    'logged in typescript.ts'

test/snapshots/protocol-ava-3.js.snap

@@ -0,0 +1,8 @@
+{
+	"compilerOptions": {
+		"outDir": "fixtures/compiled"
+	},
+	"include": [
+		"fixtures"
+	]
+}