-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stopped working? #1
Comments
Can you please share these details?
It should most probably be something easy to fix. |
iOS 18
( reference: https://www.ios-resolution.com/ ) I have spent literally 6 hours trying to debug this with web inspector and cache clearing / busting and trying all kinds of crazy stuff. 😅 The link tags are being generated, the data URLs work when I copy and paste them into the browser location bar. PNG gets downloaded and is the right size. The image that is generated is 3x (pixelRatio) the I added the Here is the code change I made to your (brilliant!) script: const appleTouchStartupImageLink = document.createElement('link');
appleTouchStartupImageLink.setAttribute('rel', 'apple-touch-startup-image');
// appleTouchStartupImageLink.setAttribute('media', "screen and (orientation: portrait)");
appleTouchStartupImageLink.setAttribute('media', "screen and (device-width: "+window.innerWidth+"px) and (device-height: 852px) and (-webkit-device-pixel-ratio: "+pixelRatio+") and (orientation: portrait)");
appleTouchStartupImageLink.setAttribute('href', imageDataURL);
document.head.appendChild(appleTouchStartupImageLink); When I hard code an actual png, it works. (And oddly it works without a |
Filed a bug report https://bugs.webkit.org/show_bug.cgi?id=280262 It's strange that they disabled |
@BorisAnthony I just tested this on iOS 18 on an iPhone 16 Pro and this works for me. Note that you need to add the @avadhesh18 You may want to consider adding this to the README file, so it's clear that this tag is needed for this to work. |
@ryanbrill, the tag is present. 😅 As mentioned above, I have now spent well over 8 hours trying to figure this out. I have tried every permutation of meta and link tags, manifests, clear caches and rebooted the device many, many times. Not having official documentation from Apple about what they actually require/look for, not any known way to observe the web app installation process (to see what's going on). One hilarious fact: it works on a fully updated iPad Pro (10.5-inch), which just got dropped from iPadOS updates and will forever more be stuck at 17.7… I should mention, I noticed this stopped working this past spring but I didn't have the time then to dive into fixing it. I should have noted the iOS version, but as @avadhesh18 noted in the webkit bug report, it was still working on iOS 17.5.1 My next, and last step, is to set up a bare test, which I will commit and share here… now that webkit team is looking… 👀 p.s.: @avadhesh18 's demo also does not work for me on my iPhone 15 Pro / iOS 18.0 |
So, I set up a minimal test. If you want to try it out: As the Readme says, at this point I only have evidence that the test doesn't work on my iPhone 15 Pro/18.0. Happy to get your results. 🙏🏼 |
@BorisAnthony Your test page works for me on iPhone 16 Pro running iOS 18.0. |
I have a confirmed case of another iPhone 16 Pro/iOS 18.0 where it doesn't work. 🤔 ScreenRecording_09-25-2024.07-52-38_1.MP4 |
for me iPhone SE it never works either |
Is there anyway you can enable the crossorigin anonymous as an option? |
@BorisAnthony I stumbled across this I have an iPhone 15 Pro on iOS 18.3.1 and cannot get this to work either, nor your POC, nor by hard-coding touch icons into the HTML and manifest.json file. My hypothesis is that this is a bug with Apple. |
It works for me on iPhone 13 Pro on iOS 18.1.1, and even added the page from private mode (#3). Before adding the |
Sadly this brilliant brilliant solution seems to have stopped working. Even your demo longer works.
Either Apple made it so the file must be served and can't be injected via a
data:
url, or they are strictly looking for an http media-type header.The text was updated successfully, but these errors were encountered: