Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix some comments #1431

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/simulator/config/flags.go
Original file line number Diff line number Diff line change
Expand Up @@ -125,5 +125,5 @@ func addSimulatorFlags(fs *pflag.FlagSet) {
fs.String(LogLevelKey, "info", "Specify the log level to use in the simulator")
fs.Uint64(BatchSizeKey, 100, "Specify the batchsize for the worker to issue and confirm txs")
fs.Uint64(MetricsPortKey, 8082, "Specify the port to use for the metrics server")
fs.String(MetricsOutputKey, "", "Specify the file to write metrics in json format, or empy to write to stdout (defaults to stdout)")
fs.String(MetricsOutputKey, "", "Specify the file to write metrics in json format, or empty to write to stdout (defaults to stdout)")
}
2 changes: 1 addition & 1 deletion core/evm.go
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ func NewEVMBlockContext(header *types.Header, chain ChainContext, author *common
// NewEVMBlockContextWithPredicateResults creates a new context for use in the EVM with an override for the predicate results that is not present
// in header.Extra.
// This function is used to create a BlockContext when the header Extra data is not fully formed yet and it's more efficient to pass in predicateResults
// directly rather than re-encode the latest results when executing each individaul transaction.
// directly rather than re-encode the latest results when executing each individual transaction.
func NewEVMBlockContextWithPredicateResults(header *types.Header, chain ChainContext, author *common.Address, predicateResults *predicate.Results) vm.BlockContext {
return newEVMBlockContext(header, chain, author, predicateResults)
}
Expand Down
2 changes: 1 addition & 1 deletion core/predicate_check_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ func TestCheckPredicate(t *testing.T) {
},
expectedErr: nil,
},
"two predicates niether named by access list": {
"two predicates neither named by access list": {
gas: 61600,
predicateContext: predicateContext,
createPredicates: func(t testing.TB) map[common.Address]precompileconfig.Predicater {
Expand Down
2 changes: 1 addition & 1 deletion precompile/contracts/rewardmanager/contract.go
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ func GetStoredRewardAddress(stateDB contract.StateDB) (common.Address, bool) {
return common.BytesToAddress(val.Bytes()), val == allowFeeRecipientsAddressValue
}

// StoredRewardAddress stores the given [val] under rewardAddressStorageKey.
// StoreRewardAddress stores the given [val] under rewardAddressStorageKey.
func StoreRewardAddress(stateDB contract.StateDB, val common.Address) {
stateDB.SetState(ContractAddress, rewardAddressStorageKey, common.BytesToHash(val.Bytes()))
}
Expand Down
2 changes: 1 addition & 1 deletion precompile/contracts/rewardmanager/contract_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -366,7 +366,7 @@ var (
ReadOnly: true,
ExpectedErr: vmerrs.ErrWriteProtection.Error(),
},
"readOnly set reward addresss with allowed role fails": {
"readOnly set reward address with allowed role fails": {
Caller: allowlist.TestEnabledAddr,
BeforeHook: allowlist.SetDefaultRoles(Module.Address),
InputFn: func(t testing.TB) []byte {
Expand Down
Loading