nits

Signed-off-by: Sam Batschelet <[email protected]>

Author: hexfusion

scripts/tests.e2e.sh

@@ -1,17 +1,17 @@
 #!/usr/bin/env bash
 set -e
 
-# build spacesvm-rs binary
+# build spacesvm binary
 # ./scripts/build.release.sh
 #
 # download from github, keep network running
-# VM_PLUGIN_PATH=$(pwd)/target/release/spacesvm-rs ./scripts/tests.e2e.sh
+# VM_PLUGIN_PATH=$(pwd)/target/release/spacesvm ./scripts/tests.e2e.sh
 #
 # download from github, shut down network
-# NETWORK_RUNNER_ENABLE_SHUTDOWN=1 VM_PLUGIN_PATH=$(pwd)/target/release/spacesvm-rs ./scripts/tests.e2e.sh
+# NETWORK_RUNNER_ENABLE_SHUTDOWN=1 VM_PLUGIN_PATH=$(pwd)/target/release/spacesvm ./scripts/tests.e2e.sh
 #
 # use custom avalanchego binary
-# VM_PLUGIN_PATH=$(pwd)/target/release/timestampvm ./scripts/tests.e2e.sh ~/go/src/github.com/ava-labs/avalanchego/build/avalanchego
+# VM_PLUGIN_PATH=$(pwd)/target/release/spacesvm ./scripts/tests.e2e.sh ~/go/src/github.com/ava-labs/avalanchego/build/avalanchego
 #
 if ! [[ "$0" =~ scripts/tests.e2e.sh ]]; then
   echo "must be run from repository root"

spaces-cli/src/bin/spaces-cli/main.rs

@@ -43,8 +43,8 @@ struct Cli {
     #[command(subcommand)]
     command: Command,
 }
-
-fn main() -> Result<(), Box<dyn error::Error>> {
+#[tokio::main]
+async fn main() -> Result<(), Box<dyn error::Error>> {
     let cli = Cli::parse();
 
     let private_key = get_or_create_pk(&cli.private_key_file)?;

spacesvm/src/api/client.rs

@@ -81,7 +81,7 @@ impl Client<HttpConnector> {
     /// Returns a recoverable signature from bytes.
     pub fn sign_digest(&self, dh: &[u8]) -> Result<Sig> {
         if let Some(pk) = &self.private_key {
-            pk.sign_digest(dh)?;
+            return pk.sign_digest(dh);
         }
         Err(Error::new(ErrorKind::Other, "private key not set"))
     }
@@ -125,15 +125,14 @@ impl Client<HttpConnector> {
             space: space.as_bytes().to_vec(),
             key: key.as_bytes().to_vec(),
         })?;
-        let (_id, json_request) = self.raw_request("issueTx", &Params::Array(vec![arg_value]));
+        let (_id, json_request) = self.raw_request("resolve", &Params::Array(vec![arg_value]));
         let resp = self.post_de::<ResolveResponse>(&json_request).await?;
 
         Ok(resp)
     }
 
     /// Returns a deserialized response from client request.
     pub async fn post_de<T: de::DeserializeOwned>(&self, json: &str) -> Result<T> {
-        println!("json: {}", json);
         let req = Request::builder()
             .method(Method::POST)
             .uri(self.endpoint.to_string())
@@ -221,8 +220,8 @@ pub fn get_or_create_pk(path: &str) -> Result<key::secp256k1::private_key::Key>
         .map_err(|e| std::io::Error::new(std::io::ErrorKind::Other, e.to_string()))
 }
 
-#[tokio::test]
-async fn test_raw_request() {
+#[test]
+fn test_raw_request() {
     let mut cli = Client::new(Uri::from_static("http://test.url"));
     let (id, _) = cli.raw_request("ping", &Params::None);
     assert_eq!(id, jsonrpc_core::Id::Num(0));

tests/e2e/src/tests/mod.rs

@@ -33,7 +33,7 @@ async fn e2e() {
     assert!(exists);
     assert!(Path::new(&vm_plugin_path).exists());
 
-    let vm_id = subnet::vm_name_to_id("minikvvm").unwrap();
+    let vm_id = subnet::vm_name_to_id("spacesvm").unwrap();
 
     let (mut avalanchego_exec_path, _) = crate::get_avalanchego_path();
     let plugins_dir = if !avalanchego_exec_path.is_empty() {
@@ -50,7 +50,7 @@ async fn e2e() {
         // keep this in sync with "proto" crate
         // ref. https://github.com/ava-labs/avalanchego/blob/v1.9.2/version/constants.go#L15-L17
         let (exec_path, plugins_dir) =
-            avalanche_installer::avalanchego::download(None, None, Some("v1.9.2".to_string()))
+            avalanche_installer::avalanchego::download(None, None, Some("v1.9.3".to_string()))
                 .await
                 .unwrap();
         avalanchego_exec_path = exec_path;