-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: change how addresses are derived #133
Open
meeh0w
wants to merge
20
commits into
main
Choose a base branch
from
feat/solana-secrets
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+4,696
−1,591
Open
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
850bc76
refactor: change how addresses are derived
meeh0w e71788b
docs: diagram of address derivation flow
meeh0w f4f44aa
fix: seedphrase onboarding
meeh0w bf383ae
fix: seedless & ledger live onboarding
meeh0w f92ba8a
fix: keystone onboarding
meeh0w 2d7c552
fix: account list when address not present
meeh0w e332bef
Merge remote-tracking branch 'origin/main' into feat/solana-secrets
meeh0w 80464ab
fix: self-review issues
meeh0w 3c7675b
fix: some fixes & tests for AddressPublicKey class
meeh0w 646b3a2
test: missing specs for AddressResolver
meeh0w 84a9dfb
fix: migration types & tests
meeh0w 28d67b5
fix: further fixes to schema migration
meeh0w 55861af
Merge remote-tracking branch 'origin/main' into feat/solana-secrets
meeh0w de736d1
chore: types
meeh0w 15c64e5
fix: missing error messages
meeh0w ebacc91
chore: translations
meeh0w fd4e395
Merge remote-tracking branch 'origin/main' into feat/solana-secrets
meeh0w d218327
fix: use publicKeyRaw instead of publicKey
meeh0w a9ddc32
fix: conflict resolution issue
meeh0w 78bdbb3
Merge remote-tracking branch 'origin/main' into feat/solana-secrets
meeh0w File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
v20.11.0 | ||
v20.18.0 |
Large diffs are not rendered by default.
Oops, something went wrong.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -23,9 +23,9 @@ | |
"sentry": "node sentryscript.js" | ||
}, | ||
"dependencies": { | ||
"@avalabs/avalanche-module": "1.4.3", | ||
"@avalabs/avalanche-module": "0.0.0-feat-solana-address-resolution-20250205161605", | ||
"@avalabs/avalanchejs": "4.2.0-alpha.1", | ||
"@avalabs/bitcoin-module": "1.4.3", | ||
"@avalabs/bitcoin-module": "0.0.0-feat-solana-address-resolution-20250205161605", | ||
"@avalabs/bridge-unified": "4.0.1", | ||
"@avalabs/core-bridge-sdk": "3.1.0-alpha.37", | ||
"@avalabs/core-chains-sdk": "3.1.0-alpha.37", | ||
|
@@ -37,12 +37,12 @@ | |
"@avalabs/core-token-prices-sdk": "3.1.0-alpha.37", | ||
"@avalabs/core-utils-sdk": "3.1.0-alpha.37", | ||
"@avalabs/core-wallets-sdk": "3.1.0-alpha.37", | ||
"@avalabs/evm-module": "1.4.3", | ||
"@avalabs/evm-module": "0.0.0-feat-solana-address-resolution-20250205161605", | ||
"@avalabs/glacier-sdk": "3.1.0-alpha.37", | ||
"@avalabs/hw-app-avalanche": "0.14.1", | ||
"@avalabs/hvm-module": "1.4.3", | ||
"@avalabs/hvm-module": "0.0.0-feat-solana-address-resolution-20250205161605", | ||
"@avalabs/types": "3.1.0-alpha.37", | ||
"@avalabs/vm-module-types": "1.4.3", | ||
"@avalabs/vm-module-types": "0.0.0-feat-solana-address-resolution-20250205161605", | ||
"@blockaid/client": "0.10.0", | ||
"@coinbase/cbpay-js": "1.6.0", | ||
"@cubist-labs/cubesigner-sdk": "0.3.28", | ||
|
@@ -61,6 +61,7 @@ | |
"@noble/curves": "1.6.0", | ||
"@noble/hashes": "1.3.2", | ||
"@openzeppelin/contracts": "4.9.6", | ||
"@scure/base": "1.2.4", | ||
"@sentry/browser": "7.66.0", | ||
"@sentry/integrations": "7.66.0", | ||
"@sentry/react": "7.66.0", | ||
|
@@ -88,6 +89,7 @@ | |
"ledger-bitcoin": "0.2.3", | ||
"lodash": "4.17.21", | ||
"lru-cache": "7.10.1", | ||
"micro-key-producer": "0.7.5", | ||
"micro-signals": "2.4.0", | ||
"paraswap": "5.1.0", | ||
"qrcode.react": "1.0.1", | ||
|
@@ -224,7 +226,7 @@ | |
"*.{ts,tsx}": "eslint --fix --max-warnings 0" | ||
}, | ||
"volta": { | ||
"node": "20.11.0", | ||
"node": "20.18.0", | ||
"yarn": "1.22.19" | ||
}, | ||
"lavamoat": { | ||
|
@@ -272,7 +274,9 @@ | |
"@avalabs/core-bridge-sdk>@avalabs/core-wallets-sdk>@metamask/eth-sig-util>@metamask/utils>@ethereumjs/tx>@ethereumjs/common>ethereumjs-util>ethereum-cryptography>keccak": false, | ||
"@avalabs/avalanche-module>@avalabs/vm-module-types>hypersdk-client>@metamask/sdk>@metamask/sdk-communication-layer>bufferutil": false, | ||
"@avalabs/avalanche-module>@avalabs/vm-module-types>hypersdk-client>@metamask/sdk>@metamask/sdk-communication-layer>utf-8-validate": false, | ||
"@avalabs/avalanche-module>@avalabs/vm-module-types>hypersdk-client>@metamask/sdk>eciesjs>secp256k1": false | ||
"@avalabs/avalanche-module>@avalabs/vm-module-types>hypersdk-client>@metamask/sdk>eciesjs>secp256k1": false, | ||
"@avalabs/avalanche-module>@avalabs/core-wallets-sdk>@metamask/eth-sig-util>ethereumjs-abi>ethereumjs-util>ethereum-cryptography>keccak": false, | ||
"@avalabs/avalanche-module>@avalabs/core-wallets-sdk>@metamask/eth-sig-util>ethereumjs-abi>ethereumjs-util>ethereum-cryptography>secp256k1": false | ||
} | ||
}, | ||
"packageManager": "[email protected]+sha1.4ba7fc5c6e704fce2066ecbfb0b0d8976fe62447" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to define the addressResolver here?
Can it just inject the moduleManager via DI like it does with it's other dependencies