remove busy waiting for blockchain rpc endpoints on local network deploy #2600
+3
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Currently local network blockchain deploy waits for rpc endpoints to be ready before considering
the deploy finished. The rpc check is based in calling a Subnet-Evm function.
This is not compatible at all with custom vms.
For subnet-evm it is enough to wait for the blockchain to be bootstrapped, afterwards we can consider
the rpcs to be available.
How this works
Remove the busy wait for rpc availability based on subnet-evm call. Keeps the wait for bootstrapped blockchain.
How this was tested
How is this documented