Refuse finalizing a timed out round despite being notarized #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yacovm
force-pushed
the
notarizationEmptyNot
branch
from
be3f945 to
54e2fdd
Compare
This commit makes it that: 1) Nodes can accept a notarization of a block that they timed out on 2) Nodes will not vote on a block that they timed out on. 3) Nodes will not broadcast a finalization of a block that they accepted its notarization. Signed-off-by: Yacov Manevich <[email protected]>
yacovm
force-pushed
the
notarizationEmptyNot
branch
from
54e2fdd to
bc2a589
Compare
samliok
approved these changes
Feb 25, 2025
| @@ -858,6 +858,16 @@ func (mem *InMemStorage) waitForBlockCommit(seq uint64) Block { | |||
| } | |||
| } | |||
|
|
|||
| func (mem *InMemStorage) ensureNoBlockCommit(t *testing.T, seq uint64) { | |||
| require.Never(t, func() bool { | |||
There was a problem hiding this comment.
interesting, haven't seen Never used before. For readability though, i think it would make sense to create the helper function and pass it in, rather than creating it as a parameter.
There was a problem hiding this comment.
Generally yes, but this is a utility method of the InMemStorage that is re-usable.
If I extract the passed callback to a function, the method would be a one-liner.
I'm not sure it's worth it, as the function extracted then will not be re-usable for anything other than the InMemStorage.
what do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes it that: