Don't Send FutureFCertRequests if currently verifying proposal. #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samliok
commented
Feb 19, 2025
samliok
force-pushed
the
future-fcert
branch
from
6950b23 to
aa843a2
Compare
yacovm
reviewed
Feb 20, 2025
yacovm
reviewed
Feb 20, 2025
samliok
force-pushed
the
future-fcert
branch
from
5358e99 to
1296e60
Compare
yacovm
reviewed
Feb 20, 2025
yacovm
reviewed
Feb 20, 2025
replication_test.go
Outdated
|
|
||
| storedBlock := storage.waitForBlockCommit(0) | ||
| require.Equal(t, uint64(1), storage.Height()) | ||
| // make sure it was indexed and no replication requests where sent |
There was a problem hiding this comment.
we don't check that no replication requests were sent though
There was a problem hiding this comment.
yea, i think checking for sent requests is actually unnecessary so i'm going to delete the comment
yacovm
reviewed
Feb 20, 2025
samliok
force-pushed
the
future-fcert
branch
from
281170d to
3f0dba2
Compare
yacovm
reviewed
Feb 20, 2025
yacovm
reviewed
Feb 20, 2025
yacovm
reviewed
Feb 21, 2025
yacovm
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #81