Store future notarization message #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yacovm
force-pushed
the
handleNotarizationFutureRound
branch
from
094f45f to
654b689
Compare
samliok
approved these changes
Feb 25, 2025
epoch_test.go
Outdated
Comment on lines
29
to
40
| bb := &testBlockBuilder{out: make(chan *testBlock, 2), in: make(chan *testBlock, 1)} | ||
|
|
||
| nodes := []NodeID{{1}, {2}, {3}, {4}} | ||
|
|
||
| // Create the two blocks ahead of time | ||
| blocks := createBlocks(t, nodes, bb, 2) | ||
|
|
||
| firstBlock := blocks[0].Block.(*testBlock) | ||
| secondBlock := blocks[1].Block.(*testBlock) | ||
|
|
||
| // re-create the block builder | ||
| bb = &testBlockBuilder{out: make(chan *testBlock, 1), in: make(chan *testBlock, 1)} |
There was a problem hiding this comment.
would it be simpler to do something like this?
Suggested change
| bb := &testBlockBuilder{out: make(chan *testBlock, 2), in: make(chan *testBlock, 1)} | |
| nodes := []NodeID{{1}, {2}, {3}, {4}} | |
| // Create the two blocks ahead of time | |
| blocks := createBlocks(t, nodes, bb, 2) | |
| firstBlock := blocks[0].Block.(*testBlock) | |
| secondBlock := blocks[1].Block.(*testBlock) | |
| // re-create the block builder | |
| bb = &testBlockBuilder{out: make(chan *testBlock, 1), in: make(chan *testBlock, 1)} | |
| bb := &testBlockBuilder{} | |
| nodes := []NodeID{{1}, {2}, {3}, {4}} | |
| // Create the two blocks ahead of time | |
| blocks := createBlocks(t, nodes, bb, 2) | |
| firstBlock := blocks[0].Block.(*testBlock) | |
| secondBlock := blocks[1].Block.(*testBlock) | |
| bb.out = make(chan *testBlock, 1) | |
| bb.in = make(chan *testBlock, 1) |
epoch_test.go
Outdated
| injectTestFinalization(t, e, secondBlock, nodes[i]) | ||
| } | ||
|
|
||
| storage.waitForBlockCommit(1) |
There was a problem hiding this comment.
might as well assert the block returned here is as expected
yacovm
force-pushed
the
handleNotarizationFutureRound
branch
from
654b689 to
5f0d461
Compare
We may receive a notarization message for a future round, and in that case - when we move to that round and finish verifying the proposal, we can just use it to advance to the next round. Signed-off-by: Yacov Manevich <[email protected]>
yacovm
force-pushed
the
handleNotarizationFutureRound
branch
from
5f0d461 to
db223b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We may receive a notarization message for a future round, and in that case - when we move to that round and finish verifying the proposal, we can just use it to advance to the next round.