Skip to content

Commit 7e509a6

Browse files
authored
Code Cleanup and Autoformat (astuff#52)
* Cleanup CMakeLists.txt and package.xml * Run auto-formatter * Re-org some things, update diagnostics updater * Remove boost usage * Run auto-formatter again * Add missing mutex include
1 parent ab14601 commit 7e509a6

18 files changed

+1031
-1106
lines changed

CMakeLists.txt

Lines changed: 14 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,11 @@ find_package(catkin REQUIRED COMPONENTS
55
camera_info_manager
66
diagnostic_updater
77
dynamic_reconfigure
8-
image_geometry
98
image_transport
109
message_filters
1110
roscpp
1211
sensor_msgs
1312
std_msgs
14-
polled_camera
1513
nodelet
1614
)
1715

@@ -27,7 +25,7 @@ generate_dynamic_reconfigure_options(
2725

2826
catkin_package(
2927
INCLUDE_DIRS include
30-
CATKIN_DEPENDS camera_info_manager diagnostic_updater dynamic_reconfigure image_geometry image_transport roscpp sensor_msgs std_msgs polled_camera
28+
CATKIN_DEPENDS camera_info_manager diagnostic_updater dynamic_reconfigure image_transport roscpp sensor_msgs std_msgs
3129
)
3230

3331
###########
@@ -41,14 +39,14 @@ include_directories(
4139

4240
# C++11 support
4341
include(CheckCXXCompilerFlag)
44-
CHECK_CXX_COMPILER_FLAG("-std=c++11" COMPILER_SUPPORTS_CXX11)
42+
CHECK_CXX_COMPILER_FLAG("-std=c++14" COMPILER_SUPPORTS_CXX11)
4543
CHECK_CXX_COMPILER_FLAG("-std=c++0x" COMPILER_SUPPORTS_CXX0X)
4644
if(COMPILER_SUPPORTS_CXX11)
47-
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++11")
45+
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++14")
4846
elseif(COMPILER_SUPPORTS_CXX0X)
4947
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++0x")
5048
else()
51-
message(STATUS "The compiler ${CMAKE_CXX_COMPILER} has no C++11 support. Please use a different C++ compiler.")
49+
message(STATUS "The compiler ${CMAKE_CXX_COMPILER} has no C++14 support. Please use a different C++ compiler.")
5250
endif()
5351

5452
function(add_dependencies_and_linkings arg)
@@ -79,42 +77,46 @@ function(add_dependencies_and_linkings arg)
7977
endif()
8078
endfunction(add_dependencies_and_linkings)
8179

80+
# Nodes
8281
add_executable(mono_camera_node
8382
src/nodes/mono_camera_node.cpp
8483
src/mono_camera.cpp
8584
src/avt_vimba_camera.cpp
8685
src/frame_observer.cpp
8786
)
88-
8987
add_dependencies_and_linkings(mono_camera_node)
9088

9189
add_executable(sync_node
9290
src/nodes/sync_node.cpp
9391
src/sync.cpp
9492
)
95-
9693
add_dependencies_and_linkings(sync_node)
9794

9895
add_executable(trigger_node
9996
src/nodes/trigger_node.cpp
10097
src/trigger.cpp
10198
)
102-
10399
add_dependencies_and_linkings(trigger_node)
104100

101+
# Nodelets
105102
add_library(avt_camera_nodelets
106103
src/nodes/mono_camera_nodelet.cpp
107104
src/mono_camera.cpp
108105
src/avt_vimba_camera.cpp
109-
src/frame_observer.cpp)
106+
src/frame_observer.cpp
107+
)
110108
add_dependencies_and_linkings(avt_camera_nodelets)
111109

112110
#############
113111
## Install ##
114112
#############
115113

116114
## Mark executables and/or libraries for installation
117-
install(TARGETS mono_camera_node avt_camera_nodelets
115+
install(TARGETS
116+
mono_camera_node
117+
sync_node
118+
trigger_node
119+
avt_camera_nodelets
118120
ARCHIVE DESTINATION ${CATKIN_PACKAGE_LIB_DESTINATION}
119121
LIBRARY DESTINATION ${CATKIN_PACKAGE_LIB_DESTINATION}
120122
RUNTIME DESTINATION ${CATKIN_PACKAGE_BIN_DESTINATION}
@@ -124,11 +126,11 @@ install(TARGETS mono_camera_node avt_camera_nodelets
124126
install(DIRECTORY include
125127
DESTINATION ${CATKIN_PACKAGE_INCLUDE_DESTINATION}
126128
FILES_MATCHING PATTERN "*.h"
127-
PATTERN ".svn" EXCLUDE
128129
)
129130

130131
## Mark other files for installation (e.g. launch and bag files, etc.)
131132
install(FILES
133+
README.md
132134
plugins.xml
133135
DESTINATION ${CATKIN_PACKAGE_SHARE_DESTINATION}
134136
)

0 commit comments

Comments
 (0)