Update some comments

Author: liuchengxu

crates/subspace-fraud-proof/src/lib.rs

@@ -61,7 +61,7 @@ where
         execution_phase: &ExecutionPhase,
         delta_changes: Option<(DB, Block::Hash)>,
     ) -> sp_blockchain::Result<StorageProof> {
-        // TODO: fetch the runtime code properly.
+        // TODO: fetch the runtime code from the primary chain instead of the local state.
         let state = self.backend.state_at(at)?;
 
         let trie_backend = state.as_trie_backend().ok_or_else(|| {
@@ -74,6 +74,8 @@ where
             .runtime_code()
             .map_err(sp_blockchain::Error::RuntimeCode)?;
 
+        // TODO: avoid using the String API specified by `proving_method()`
+        // https://github.com/paritytech/substrate/discussions/11095
         if let Some((delta, post_delta_root)) = delta_changes {
             let delta_backend = create_delta_backend(trie_backend, delta, post_delta_root);
             sp_state_machine::prove_execution_on_trie_backend(
@@ -114,7 +116,7 @@ where
         pre_execution_root: H256,
         proof: StorageProof,
     ) -> sp_blockchain::Result<Vec<u8>> {
-        // TODO: fetch the runtime code properly.
+        // TODO: fetch the runtime code from the primary chain instead of the local state.
         let state = self.backend.state_at(at)?;
 
         let trie_backend = state.as_trie_backend().ok_or_else(|| {

cumulus/client/cirrus-executor/src/lib.rs

@@ -341,8 +341,6 @@ where
 
 		let delta = storage_changes.transaction;
 		let post_delta_root = storage_changes.transaction_storage_root;
-		// TODO: way to call some runtime api against any specific state instead of having
-		// to work with String API directly.
 		let execution_proof = prover.prove_execution(
 			BlockId::Hash(parent_header.hash()),
 			&execution_phase,
@@ -614,8 +612,6 @@ where
 				let execution_phase =
 					ExecutionPhase::InitializeBlock { call_data: new_header.encode() };
 
-				// TODO: way to call some runtime api against any specific state instead of having
-				// to work with String API directly.
 				let proof = prover.prove_execution::<TransactionFor<Backend, Block>>(
 					BlockId::Hash(parent_header.hash()),
 					&execution_phase,
@@ -650,8 +646,6 @@ where
 				let delta = storage_changes.transaction;
 				let post_delta_root = storage_changes.transaction_storage_root;
 
-				// TODO: way to call some runtime api against any specific state instead of having
-				// to work with String API directly.
 				let proof = prover.prove_execution(
 					BlockId::Hash(parent_header.hash()),
 					&execution_phase,

cumulus/client/cirrus-executor/src/tests.rs

@@ -183,7 +183,7 @@ async fn execution_proof_creation_and_verification_should_work() {
 		)
 		.expect("Create `initialize_block` proof");
 
-	// Test `initialize_block` verification on executor.
+	// Test `initialize_block` verification.
 	let execution_result = prover
 		.check_execution_proof(
 			BlockId::Hash(parent_header.hash()),
@@ -196,7 +196,6 @@ async fn execution_proof_creation_and_verification_should_work() {
 		execution_phase.decode_execution_result::<Header>(execution_result).unwrap();
 	assert_eq!(post_execution_root, intermediate_roots[0].into());
 
-	// Test `initialize_block` verification on farmer.
 	let proof_verifier = subspace_fraud_proof::ProofVerifier::new(
 		alice.client.clone(),
 		alice.backend.clone(),
@@ -240,7 +239,7 @@ async fn execution_proof_creation_and_verification_should_work() {
 		let target_trace_root: Hash = intermediate_roots[target_extrinsic_index].into();
 		assert_eq!(target_trace_root, post_delta_root);
 
-		// Test `apply_extrinsic` verification on executor.
+		// Test `apply_extrinsic` verification.
 		let execution_result = prover
 			.check_execution_proof(
 				BlockId::Hash(parent_header.hash()),
@@ -253,7 +252,6 @@ async fn execution_proof_creation_and_verification_should_work() {
 			execution_phase.decode_execution_result::<Header>(execution_result).unwrap();
 		assert_eq!(post_execution_root, intermediate_roots[target_extrinsic_index + 1].into());
 
-		// Test `apply_extrinsic` verification on farmer.
 		let fraud_proof = FraudProof {
 			parent_hash: parent_hash_alice,
 			pre_state_root: intermediate_roots[target_extrinsic_index].into(),
@@ -284,7 +282,7 @@ async fn execution_proof_creation_and_verification_should_work() {
 		)
 		.expect("Create `finalize_block` proof");
 
-	// Test `finalize_block` verification on executor.
+	// Test `finalize_block` verification.
 	let execution_result = prover
 		.check_execution_proof(
 			BlockId::Hash(parent_header.hash()),
@@ -297,7 +295,6 @@ async fn execution_proof_creation_and_verification_should_work() {
 		execution_phase.decode_execution_result::<Header>(execution_result).unwrap();
 	assert_eq!(post_execution_root, *header.state_root());
 
-	// Test `finalize_block` verification on farmer.
 	let fraud_proof = FraudProof {
 		parent_hash: parent_hash_alice,
 		pre_state_root: intermediate_roots.last().unwrap().into(),