Skip to content

Commit c827329

Browse files
authored
Changed pull_request_target to pull_request (#194)
### Changes - Change pull_request_target to pull_request for better security. - Remove the authorize job from the list of jobs defined in that workflow. - Remove the dependency on authorize job for other jobs in that workflow by looking for the line needs: authorize. ### Checklist [ ] I have read the [Auth0 general contribution guidelines](https://github.com/auth0/open-source-template/blob/master/GENERAL-CONTRIBUTING.md) [ ] I have read the [Auth0 Code of Conduct](https://github.com/auth0/open-source-template/blob/master/CODE-OF-CONDUCT.md) [ ] All existing and new tests complete without errors
2 parents 24ae10f + e758a1a commit c827329

File tree

3 files changed

+3
-28
lines changed

3 files changed

+3
-28
lines changed

.github/workflows/semgrep.yml

+1-10
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ name: Semgrep
22

33
on:
44
merge_group:
5-
pull_request_target:
5+
pull_request:
66
types:
77
- opened
88
- synchronize
@@ -20,16 +20,7 @@ concurrency:
2020
cancel-in-progress: ${{ github.ref != 'refs/heads/main' }}
2121

2222
jobs:
23-
authorize:
24-
name: Authorize
25-
environment: ${{ github.actor != 'dependabot[bot]' && github.event_name == 'pull_request_target' && github.event.pull_request.head.repo.full_name != github.repository && 'external' || 'internal' }}
26-
runs-on: ubuntu-latest
27-
steps:
28-
- run: true
29-
3023
check:
31-
needs: authorize
32-
3324
name: Check for Vulnerabilities
3425
runs-on: ubuntu-latest
3526

.github/workflows/snyk.yml

+1-9
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ name: Snyk
22

33
on:
44
merge_group:
5-
pull_request_target:
5+
pull_request:
66
types:
77
- opened
88
- synchronize
@@ -26,16 +26,8 @@ concurrency:
2626
cancel-in-progress: ${{ github.ref != 'refs/heads/main' }}
2727

2828
jobs:
29-
authorize:
30-
name: Authorize
31-
environment: ${{ github.actor != 'dependabot[bot]' && github.event_name == 'pull_request_target' && github.event.pull_request.head.repo.full_name != github.repository && 'external' || 'internal' }}
32-
runs-on: ubuntu-latest
33-
steps:
34-
- run: true
35-
3629
configure:
3730
name: Configure
38-
needs: [authorize]
3931
runs-on: ubuntu-latest
4032

4133
outputs:

.github/workflows/tests.yml

+1-9
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ name: Build and Test
22

33
on:
44
merge_group:
5-
pull_request_target:
5+
pull_request:
66
types:
77
- opened
88
- synchronize
@@ -17,16 +17,8 @@ concurrency:
1717
cancel-in-progress: ${{ github.ref != 'refs/heads/main' }}
1818

1919
jobs:
20-
authorize:
21-
name: Authorize
22-
environment: ${{ github.actor != 'dependabot[bot]' && github.event_name == 'pull_request_target' && github.event.pull_request.head.repo.full_name != github.repository && 'external' || 'internal' }}
23-
runs-on: ubuntu-latest
24-
steps:
25-
- run: true
26-
2720
configure:
2821
name: Configure
29-
needs: [authorize]
3022
runs-on: ubuntu-latest
3123

3224
outputs:

0 commit comments

Comments
 (0)