Fix Rubocop issues

Author: Ignacio Jonas

.rubocop.yml

@@ -1,5 +1,7 @@
+inherit_from: .rubocop_todo.yml
 AllCops:
  RunRailsCops: true
  Exclude:
    - bin/**/*
    - vendor/**/*
+   - auth0.gemspec

.rubocop_todo.yml

@@ -0,0 +1,7 @@
+# Configuration parameters: CountComments.
+Metrics/MethodLength:
+  Max: 15
+
+# Configuration parameters: AllowURI, URISchemes.
+Metrics/LineLength:
+  Max: 121

Guardfile

@@ -1,7 +1,8 @@
 scope group: :unit_test
 
 group :unit_test do
-  guard 'rspec', cmd: "bundle exec rspec -P \"spec/lib/auth0/**/*#{ENV['PATTERN']}*_spec.rb\" --drb --format Fuubar --color" do
+  guard 'rspec', cmd:
+    "bundle exec rspec -P \"spec/lib/auth0/**/*#{ENV['PATTERN']}*_spec.rb\"--drb --format Fuubar --color" do
     # run every updated spec file
     watch(%r{^spec/.+_spec\.rb$})
     # run the lib specs when a file in lib/ changes
@@ -12,7 +13,8 @@ group :unit_test do
 end
 
 group :integration do
-  guard 'rspec', cmd: "MODE=full bundle exec rspec -P \"spec/integration/**/*#{ENV['PATTERN']}*_spec.rb\" --drb --format Fuubar --color" do
+  guard 'rspec', cmd:
+    "MODE=full bundle exec rspec -P \"spec/integration/**/*#{ENV['PATTERN']}*_spec.rb\" --drb --format Fuubar --color" do
     # run every updated spec file
     watch(%r{^spec/.+_spec\.rb$})
     # run the lib specs when a file in lib/ changes
@@ -23,7 +25,8 @@ group :integration do
 end
 
 group :full do
-  guard 'rspec', cmd: 'MODE=full bundle exec rspec --drb --format Fuubar --color' do
+  guard 'rspec', cmd:
+    'MODE=full bundle exec rspec --drb --format Fuubar --color' do
     # run every updated spec file
     watch(%r{^spec/.+_spec\.rb$})
     # run the lib specs when a file in lib/ changes

Rakefile

@@ -20,7 +20,7 @@ begin
   desc 'Run All Suites'
   RSpec::Core::RakeTask.new(:all)
 
-  task default: [ :rubocop, :spec ]
+  task default: [:rubocop, :spec]
 rescue LoadError
-  # No RSpec
+  puts 'Load Error - No RSpec'
 end

lib/auth0/api/authentication_endpoints.rb

@@ -3,6 +3,8 @@ module Api
     # {https://auth0.com/docs/auth-api}
     # Describing functionality of auth0 authentication endpoints
     module AuthenticationEndpoints
+      UP_AUTH = 'Username-Password-Authentication'
+
       # {https://auth0.com/docs/auth-api#!#post--oauth-access_token}
       def obtain_access_token
         request_params = {
@@ -44,7 +46,8 @@ def impersonate(user_id, app_client_id, impersonator_id, options)
       end
 
       # {https://auth0.com/docs/auth-api#!#post--oauth-ro}
-      def login(username, password, scope = 'openid', id_token = nil, connection_name = 'Username-Password-Authentication')
+
+      def login(username, password, scope = 'openid', id_token = nil, connection_name = UP_AUTH)
         request_params = {
           client_id:  @client_id,
           username:   username,
@@ -58,7 +61,7 @@ def login(username, password, scope = 'openid', id_token = nil, connection_name
       end
 
       # {https://auth0.com/docs/auth-api#!#post--dbconnections-signup}
-      def signup(email, password, connection_name = 'Username-Password-Authentication')
+      def signup(email, password, connection_name = UP_AUTH)
         request_params = {
           client_id:  @client_id,
           email:      email,
@@ -69,7 +72,7 @@ def signup(email, password, connection_name = 'Username-Password-Authentication'
       end
 
       # {https://auth0.com/docs/auth-api#!#post--dbconnections-change_password}
-      def change_password(email, password, connection_name = 'Username-Password-Authentication')
+      def change_password(email, password, connection_name = UP_AUTH)
         request_params = {
           client_id:  @client_id,
           email:      email,

lib/auth0/api/v1/connections.rb

@@ -30,8 +30,7 @@ def create_connection(connection_name, strategy, tenant_domain, domain_aliases =
             strategy: strategy,
             options: {
               tenant_domain: tenant_domain,
-              domain_aliases: domain_aliases
-            }
+              domain_aliases: domain_aliases }
           }
           post(path, request_params)
         end

lib/auth0/api/v1/logs.rb

@@ -3,21 +3,15 @@ module Api
     module V1
       # {https://auth0.com/docs/api#logs}
       module Logs
-        # {https://auth0.com/docs/api#!#get--api-logs-page--number--per_page--items--sort--field----1-1--fields--fields--exclude_fields-true-false-}
-        #
-        # {https://auth0.com/docs/api#!#get--api-logs-search--criteria-}
-        #
-        # {https://auth0.com/docs/api#!#get--api-logs-from--checkpointId--take--count-}
+        # https://auth0.com/docs/api/v1#!#logs
         def logs(options = {})
           acceptable_params = %i(take from search_criteria page per_page sort fields exclude_fields)
           options.reject! do |key, value|
-            next unless key.nil? || \
-                        value.nil? || \
-                        !acceptable_params.include?(key.to_sym)
+            next unless key.nil? || value.nil? || !acceptable_params.include?(key.to_sym)
             warn "#{key} is not in acceptable params list: #{acceptable_params}"
             true
           end
-          path = '/api/logs?' + URI.encode_www_form(options)
+          path = "/api/logs?#{URI.encode_www_form(options)}"
           get(path)
         end
 

lib/auth0/api/v1/users.rb

@@ -1,5 +1,6 @@
 module Auth0
   module Api
+    # rubocop:disable Metrics/ModuleLength
     module V1
       # {https://auth0.com/docs/api#users}
       module Users
@@ -141,7 +142,7 @@ def delete_users
 
         # {https://auth0.com/docs/api#!#delete--api-users--user_id-}
         def delete_user(user_id)
-          fail Auth0::MissingUserId, 'if you want to remove all users user delete_users method' if user_id.to_s.empty?
+          fail Auth0::MissingUserId, 'if you want to remove all users use delete_users method' if user_id.to_s.empty?
           path = "/api/users/#{user_id}"
           delete(path)
         end

lib/auth0/api/v2/clients.rb

@@ -20,7 +20,7 @@ def create_client(name, options = {})
 
         # https://auth0.com/docs/apiv2#!/clients/get_clients_by_id
         def client(client_id, options = {})
-          path = '/api/v2/clients/' + client_id.to_s
+          path = "/api/v2/clients/#{client_id}"
           get(path, options)
         end
 

lib/auth0/api/v2/connections.rb

@@ -1,6 +1,7 @@
 module Auth0
   module Api
     module V2
+      # https://auth0.com/docs/api/v2#!/Connections
       module Connections
         def connections(strategy: nil, fields: nil, include_fields: true)
           request_params = {
@@ -20,7 +21,7 @@ def create_connection(body)
         end
 
         def connection(connection_id, fields: nil, include_fields: true)
-          path = '/api/v2/connections/' + connection_id.to_s
+          path = "/api/v2/connections/#{connection_id}"
           request_params = {
             fields:         fields,
             include_fields: include_fields
@@ -36,7 +37,7 @@ def delete_connection(connection_id)
 
         def update_connection(connection_id, body)
           fail Auth0::MissingConnectionId, 'you must specify a connection id' if connection_id.to_s.empty?
-          path = '/api/v2/connections/' + connection_id.to_s
+          path = "/api/v2/connections/#{connection_id}"
           patch(path, body)
         end
       end