Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Files/Items should report to respond_to? methods that they respond to #119

Open
brandonc opened this issue Jan 12, 2017 · 0 comments
Open

Files/Items should report to respond_to? methods that they respond to #119

brandonc opened this issue Jan 12, 2017 · 0 comments

Comments

@brandonc
Copy link

Otherwise this can lead to confusing behavior:

> item.id
> "12345"
> item.try(:id)
> nil
> item.respond_to?(:id)
> false

See https://robots.thoughtbot.com/always-define-respond-to-missing-when-overriding

Corrective PR: #118
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brandonc