Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I played around with the SBOM generator and found that the
Name
field on the base image contains the registry and namespace when applicable, so I was able to mock the base image reference correctly off of the SBOM:I also updated the
mockCommonSubscriptionData
to 1) include platform, and 2) use the actual image digest from the SBOM instead of always mocking tolocalDigest
(unless SBOM isn't present).We're now parsing the SBOM twice, and I thought about trying to cache it temporarily between steps, but it became a fairly involved change. I may investigate this later as the async query portion has a similar repeat-decode behaviour with its own metadata.
Rather than mock supported tags for every execution, I'd like to only fetch it when it's actually needed from the actual policy evaluator. I'll put up a PR for that shortly in the base images repo.
Finally, I removed the local_test.go since we're no longer using that mock-by-name mechanism anyway and it was failing under the new SBOM requirement.