add subscription data source #38
Conversation
SubscriptionDataSource allows querying of objects directly from the subscription results array. It is beneficial to use this data source when it is useful to query by name, possibly allowing earlier data sources to pick up the query first (e.g. local mocking). I've also updated the local fixed data source to be a prepend action instead of append, to ensure that any local mocks are always handled first. With this, the order of options registered should not impact query behaviour.
|
Hmm, while I think this will probably work, I'm a little wary about how complex all the data source logic is getting... |
I'd love to revisit all this when we're ready to make some broader changes to local evaluation as a whole. For now, at least, I think each data source is small enough and simple enough to be easily maintainable. |
| return nil, nil | ||
| } | ||
|
|
||
| if ix >= len(ds.subscriptionResults) { |
There was a problem hiding this comment.
I don't think this is right. subscriptionResults is an array of arrays. The first array is a set of results and the second array represents the different fields within each result.
| } | ||
|
|
||
| func (ds SubscriptionDataSource) Query(_ context.Context, queryName string, _ string, _ map[string]interface{}, output interface{}) (*QueryResponse, error) { | ||
| ix, ok := ds.queryIndexes[queryName] |
There was a problem hiding this comment.
Maybe this is just personal preference, but I find it much harder to read when every entity is abbreviated.
| return nil, fmt.Errorf("can't get subscription query %s (index %d) from result length %d", queryName, ix, len(ds.subscriptionResults)) | ||
| } | ||
|
|
||
| err := edn.Unmarshal(ds.subscriptionResults[0][ix], output) |
There was a problem hiding this comment.
This is also going to have issues anyway if we need to mock fields that appear in different orders in different subscriptions. Maybe we should look at changing go-skill to support supplying keys in the subscription so that it returns a map for each result instead of an array.
| return nil, fmt.Errorf("can't get subscription query %s (index %d) from result length %d", queryName, ix, len(ds.subscriptionResults)) | ||
| } | ||
|
|
||
| err := edn.Unmarshal(ds.subscriptionResults[0][ix], output) |
There was a problem hiding this comment.
There are also cases where subscriptions can correctly return more than one result (see quality gate policy), so I'm not sure we should hardcode this to 0
Felipe has run into an issue with the non-root-user skill, since there is no longer an appropriate method for querying fields off the SyncRequest metadata. This PR adds the SubscriptionDataSource to resolve that blindspot.
SubscriptionDataSource allows querying of objects directly from the subscription results array. It is beneficial to use this data source when it is useful to query by name, possibly allowing earlier data sources to pick up the query first (e.g. local mocking).
I've also updated the local fixed data source to be a prepend action instead of append, to ensure that any local mocks are always handled first. With this, the order of options registered should not impact query behaviour.