Skip to content

Refactor Query to use iterators #532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
joepio opened this issue Nov 2, 2022 · 0 comments
Open

Refactor Query to use iterators #532

joepio opened this issue Nov 2, 2022 · 0 comments

Comments

@joepio
Copy link
Member

joepio commented Nov 2, 2022 •
edited
Loading

I've just refactored the database internals to use iterators, instead of vectors (see #529), but the Query struct still outputs a Vecs.

Iterators are more flexible and performant, but they do open up some questions:

  • The limit parameter now seems useless. Should we get rid of it?
  • Not sure if it's doable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joepio