Raw string format seems to not have grammar support

[lichaoir]

When I used r'...' in my code, the colour displayed wrong as if it didn't recognise the raw string format.

[rougeth]

It's ok here. With or without the 'r' the string is highlighted in the same way.

[lichaoir]

Sorry that I missed a key piece of info. It's the escape sequence having wrong highlight. In raw string, escape characters should be displayed as regular strings but they're not.

Thanks

On Thu, May 15, 2014 at 1:26 PM, Marco Rougeth notifications@github.com
wrote:

It's ok here. With or without the 'r' the string is highlighted in the same way.

Reply to this email directly or view it on GitHub:
#24 (comment)

[rougeth]

Could you show an example?

[lichaoir]

Sure, like below.

On Thu, May 15, 2014 at 1:49 PM, Marco Rougeth notifications@github.comwrote:

Could you show an example?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/24#issuecomment-43165864
.

[lichaoir]

Sorry, the image might not have attached correctly... here it is.

On Thu, May 15, 2014 at 3:44 PM, Chao Li lichaoir@gmail.com wrote:

Sure, like below.

On Thu, May 15, 2014 at 1:49 PM, Marco Rougeth notifications@github.comwrote:

Could you show an example?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/24#issuecomment-43165864
.

[rougeth]

I cannot see it.

[kevinsawicki]

I can't see the image either, @lichaoir would you mind trying to attach it again to a comment in this issue? Thanks

[lichaoir]

Hi Kevin & Marco,

Don't know why you guys cannot see the attached image. Here is the step to
reproduce it: try typing r'\nabc' in atom with default theme. You will see
the escape sequence \n is darkened while abc is displayed as plain string.
The thing is, since raw string content is treated as-is in python, the \n
sequence should also be displayed as plain string, namely not darkened.
Does this make sense?

Thanks

On Tue, May 20, 2014 at 6:24 AM, Kevin Sawicki notifications@github.comwrote:

I can't see the image either, @lichaoir https://github.com/lichaoirwould you mind trying to attach it again to a comment in this issue? Thanks

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/24#issuecomment-43553171
.

[warunsl]

Just so that everyone is clear, I think this is what he is talking about

The first line has \n in purple, which instead should be yellow. In a raw string in python, special/escape characters should be treated as any other character i.e., in yellow.

I think I agree with @lichaoir

[rougeth]

As the \n is a special character, I believe it is better to highlight it inside the string.

[ThinkChaos]

@rougeth In this case \n is not special!
From the docs.

>>> # Unless an 'r' or 'R' prefix is present, escape sequences in strings are interpreted
>>> r'\n' == '\\n' and r'\\' == '\\\\'
True
>>> # string quotes can be escaped with a backslash, but the backslash remains in the string
>>> r"\'" == r'\'' == "\\'"
True

[michaelstephendavies]

As far as I can tell, the package assumes all raw strings are regexes (other regex syntax like []+* etc inside raw strings gets highlighted).

[nmpeterson]

@lichaoir, @warunsl and @ThinkChaos are absolutely correct. The whole point of a raw string is to ignore the "specialness" of escape sequences. For example, I often use raw strings to set Windows-style paths (e.g. r'C:\Users\nmpeterson' and I do not want the \n within that being incorrectly highlighted as a "special" character.

[aroben]

Yes, this is a feature of the language grammar. It's trying to be helpful by highlighting raw strings as if they were regexes, since that is typically what they are used for.