Merge pull request #257 from atom/wl-sinon-deprecations

Remove uses of deprecated sinon.sandbox.create()

Author: Winston Liu

test/adapters/autocomplete-adapter.test.ts

@@ -23,13 +23,6 @@ describe('AutoCompleteAdapter', () => {
     };
   }
 
-  beforeEach(() => {
-    (global as any).sinon = sinon.sandbox.create();
-  });
-  afterEach(() => {
-    (global as any).sinon.restore();
-  });
-
   const request: ac.SuggestionsRequestedEvent = {
     editor: createFakeEditor(),
     bufferPosition: new Point(123, 456),

test/adapters/datatip-adapter.test.ts

@@ -11,13 +11,9 @@ describe('DatatipAdapter', () => {
   let connection: any;
 
   beforeEach(() => {
-    (global as any).sinon = sinon.sandbox.create();
     connection = new ls.LanguageClientConnection(createSpyConnection());
     fakeEditor = createFakeEditor();
   });
-  afterEach(() => {
-    (global as any).sinon.restore();
-  });
 
   describe('canAdapt', () => {
     it('returns true if hoverProvider is supported', () => {

test/adapters/linter-push-v2-adapter.test.ts

@@ -8,13 +8,6 @@ import { Point, Range } from 'atom';
 import { createSpyConnection, createFakeEditor } from '../helpers.js';
 
 describe('LinterPushV2Adapter', () => {
-  beforeEach(() => {
-    (global as any).sinon = sinon.sandbox.create();
-  });
-  afterEach(() => {
-    (global as any).sinon.restore();
-  });
-
   describe('constructor', () => {
     it('subscribes to onPublishDiagnostics', () => {
       const languageClient = new ls.LanguageClientConnection(createSpyConnection());

test/adapters/outline-view-adapter.test.ts

@@ -1,6 +1,5 @@
 import OutlineViewAdapter from '../../lib/adapters/outline-view-adapter';
 import * as ls from '../../lib/languageclient';
-import * as sinon from 'sinon';
 import { expect } from 'chai';
 import { Point } from 'atom';
 
@@ -14,13 +13,6 @@ describe('OutlineViewAdapter', () => {
     range: createRange(a, b, c, d),
   });
 
-  beforeEach(() => {
-    (global as any).sinon = sinon.sandbox.create();
-  });
-  afterEach(() => {
-    (global as any).sinon.restore();
-  });
-
   describe('canAdapt', () => {
     it('returns true if documentSymbolProvider is supported', () => {
       const result = OutlineViewAdapter.canAdapt({ documentSymbolProvider: true });

test/languageclient.test.ts

@@ -5,13 +5,6 @@ import { createSpyConnection } from './helpers.js';
 import { NullLogger } from '../lib/logger';
 
 describe('LanguageClientConnection', () => {
-  beforeEach(() => {
-    (global as any).sinon = sinon.sandbox.create();
-  });
-  afterEach(() => {
-    (global as any).sinon.restore();
-  });
-
   it('listens to the RPC connection it is given', () => {
     const rpc = createSpyConnection();