AXON-193: move jqls to local variable

Author: cabella-dot

src/views/jira/treeViews/customJqlViewProvider.ts

@@ -40,20 +40,18 @@ export class CustomJQLViewProvider implements TreeDataProvider<TreeItem>, Dispos
     private _onDidChangeTreeData = new EventEmitter<TreeItem | undefined | void>();
     readonly onDidChangeTreeData = this._onDidChangeTreeData.event;
 
-    private _jqlEntries: JQLEntry[] = [];
-
     constructor() {
         this._disposable = Disposable.from(
             Container.jqlManager.onDidJQLChange(this.refresh, this),
             Container.siteManager.onDidSitesAvailableChange(this.refresh, this),
             commands.registerCommand(Commands.RefreshCustomJqlExplorer, this.refresh, this),
         );
 
-        this._jqlEntries = Container.jqlManager.getCustomJQLEntries();
-
         window.createTreeView(CustomJQLViewProviderId, { treeDataProvider: this });
 
-        if (this._jqlEntries.length > 0) {
+        const jqlEntries = Container.jqlManager.getCustomJQLEntries();
+
+        if (jqlEntries.length > 0) {
             setCommandContext(CommandContext.CustomJQLExplorer, Container.config.jira.explorer.enabled);
         }
 
@@ -64,8 +62,8 @@ export class CustomJQLViewProvider implements TreeDataProvider<TreeItem>, Dispos
 
     private onConfigurationChanged(e: ConfigurationChangeEvent) {
         if (configuration.changed(e, 'jira.jqlList') || configuration.changed(e, 'jira.explorer')) {
-            this._jqlEntries = Container.jqlManager.getCustomJQLEntries();
-            if (this._jqlEntries.length > 0) {
+            const jqlEntries = Container.jqlManager.getCustomJQLEntries();
+            if (jqlEntries.length > 0) {
                 setCommandContext(CommandContext.CustomJQLExplorer, Container.config.jira.explorer.enabled);
             } else {
                 setCommandContext(CommandContext.CustomJQLExplorer, false);
@@ -90,9 +88,9 @@ export class CustomJQLViewProvider implements TreeDataProvider<TreeItem>, Dispos
         } else {
             SearchJiraHelper.clearIssues(CustomJQLViewProviderId);
 
-            this._jqlEntries = Container.jqlManager.getCustomJQLEntries();
-            return this._jqlEntries.length
-                ? this._jqlEntries.map((jqlEntry) => new JiraIssueQueryNode(jqlEntry))
+            const jqlEntries = Container.jqlManager.getCustomJQLEntries();
+            return jqlEntries.length
+                ? jqlEntries.map((jqlEntry) => new JiraIssueQueryNode(jqlEntry))
                 : [CustomJQLViewProvider._treeItemConfigureJqlMessage];
         }
     }

src/views/jira/treeViews/jiraAssignedWorkItemsViewProvider.ts

@@ -54,7 +54,7 @@ export class AssignedWorkItemsViewProvider implements TreeDataProvider<TreeItem>
         if (configuration.changed(e, 'jira.explorer.enabled')) {
             setCommandContext(CommandContext.AssignedIssueExplorer, Container.config.jira.explorer.enabled);
             this.refresh();
-        } else if (configuration.changed(e, 'jira.explorer.showIssueIcons')) {
+        } else if (configuration.changed(e, 'jira.explorer')) {
             this.refresh();
         }
     }

src/views/jira/treeViews/utils.ts

@@ -42,6 +42,7 @@ export const loginToJiraMessageNode = createLabelItem('Please login to Jira', {
     title: 'Login to Jira',
     arguments: [ProductJira],
 });
+
 export class JiraIssueNode extends TreeItem {
     private children: JiraIssueNode[];