Merge pull request #68 from atlassian-labs/enable-perm-interp

feat: enable permission checker by default

Author: jwong101

crates/fsrt/src/main.rs

@@ -76,10 +76,6 @@ pub struct Args {
     #[arg(short, long)]
     out: Option<PathBuf>,
 
-    // Run the permission checker
-    #[arg(long)]
-    check_permissions: bool,
-
     #[arg(long)]
     graphql_schema_path: Option<PathBuf>,
 
@@ -379,7 +375,7 @@ pub(crate) fn scan_directory<'a>(
         .into_iter()
         .any(|remote| remote.contains_auth());
 
-    let run_permission_checker = opts.check_permissions && !transpiled_async;
+    let run_permission_checker = !transpiled_async;
 
     let permissions_declared: HashSet<String> =
         HashSet::from_iter(permission_scopes.iter().map(|s| s.replace('\"', "")));

crates/fsrt/src/test.rs

@@ -175,7 +175,6 @@ pub(crate) fn scan_directory_test(
 
     // disallow parsing arguments meant for test harness (e.g., --nocapture, --exact) from std::env::args()
     let mut args = Args::parse_from(&[""]);
-    args.check_permissions = true;
 
     match scan_directory(PathBuf::new(), &mut args, forge_test_proj, &secret_packages) {
         Ok(report) => report,