Remove Compass resolver/permission map

Author: dxu2-atlassian

crates/forge_analyzer/src/checkers.rs

@@ -1119,10 +1119,7 @@ impl<'cx> Dataflow<'cx> for PermissionDataflow {
                     interp.bitbucket_permission_resolver,
                     interp.bitbucket_regex_map,
                 ),
-                IntrinsicName::RequestCompass => {
-                    (interp.compass_permission_resolver, interp.compass_regex_map)
-                }
-                IntrinsicName::Other => {
+                IntrinsicName::RequestCompass | IntrinsicName::Other => {
                     (&PermissionHashMap::new(), &HashMap::<String, Regex>::new())
                 }
             };

crates/forge_analyzer/src/interp.rs

@@ -396,14 +396,12 @@ pub struct Interp<'cx, C: Runner<'cx>> {
     pub jira_permission_resolver: &'cx PermissionHashMap,
     pub confluence_permission_resolver: &'cx PermissionHashMap,
     pub bitbucket_permission_resolver: &'cx PermissionHashMap,
-    pub compass_permission_resolver: &'cx PermissionHashMap,
     pub jira_any_regex_map: &'cx HashMap<String, Regex>,
     pub jira_software_regex_map: &'cx HashMap<String, Regex>,
     pub jira_service_management_regex_map: &'cx HashMap<String, Regex>,
     pub jira_regex_map: &'cx HashMap<String, Regex>,
     pub confluence_regex_map: &'cx HashMap<String, Regex>,
     pub bitbucket_regex_map: &'cx HashMap<String, Regex>,
-    pub compass_regex_map: &'cx HashMap<String, Regex>,
     _checker: PhantomData<C>,
 }
 
@@ -528,8 +526,6 @@ impl<'cx, C: Runner<'cx>> Interp<'cx, C> {
         confluence_regex_map: &'cx HashMap<String, Regex>,
         bitbucket_permission_resolver: &'cx PermissionHashMap,
         bitbucket_regex_map: &'cx HashMap<String, Regex>,
-        compass_permission_resolver: &'cx PermissionHashMap,
-        compass_regex_map: &'cx HashMap<String, Regex>,
     ) -> Self {
         let call_graph = CallGraph::new(env);
 
@@ -562,14 +558,12 @@ impl<'cx, C: Runner<'cx>> Interp<'cx, C> {
             jira_permission_resolver,
             confluence_permission_resolver,
             bitbucket_permission_resolver,
-            compass_permission_resolver,
             jira_any_regex_map,
             jira_software_regex_map,
             jira_service_management_regex_map,
             jira_regex_map,
             confluence_regex_map,
             bitbucket_regex_map,
-            compass_regex_map,
             _checker: PhantomData,
             runner_visited: RefCell::new(FxHashSet::default()),
         }

crates/forge_permission_resolver/src/permissions_resolver.rs

@@ -142,11 +142,6 @@ pub fn get_permission_resolver_bitbucket() -> (PermissionHashMap, HashMap<String
     get_permission_resolver(bitbucket_url)
 }
 
-pub fn get_permission_resolver_compass() -> (PermissionHashMap, HashMap<String, Regex>) {
-    let compass_url = "https://developer.atlassian.com/cloud/compass/swagger.v3.json";
-    get_permission_resolver(compass_url)
-}
-
 pub fn get_permission_resolver(url: &str) -> (PermissionHashMap, HashMap<String, Regex>) {
     let mut endpoint_map: PermissionHashMap = HashMap::default();
     let mut endpoint_regex: HashMap<String, Regex> = HashMap::default();
@@ -413,22 +408,6 @@ mod test {
         );
     }
 
-    #[test]
-    #[ignore]
-    fn test_resolving_compass_permissions() {
-        // TODO: it seems no permissions are being returned for compass urls
-        let (permission_map, regex_map) = get_permission_resolver_compass();
-
-        let url = "/compass/v1/events";
-        let request_type = RequestType::Post;
-        let result = check_url_for_permissions(&permission_map, &regex_map, request_type, url);
-
-        assert!(
-            !result.is_empty(),
-            "Should have parsed permissions for compass endpoint"
-        );
-    }
-
     #[test]
     fn test_get_issues_for_epic() {
         let (permission_map, regex_map) = get_permission_resolver_jira_software();

crates/fsrt/src/main.rs

@@ -6,10 +6,9 @@ mod test;
 
 use clap::{Parser, ValueHint};
 use forge_permission_resolver::permissions_resolver::{
-    get_permission_resolver_bitbucket, get_permission_resolver_compass,
-    get_permission_resolver_confluence, get_permission_resolver_jira,
-    get_permission_resolver_jira_any, get_permission_resolver_jira_service_management,
-    get_permission_resolver_jira_software,
+    get_permission_resolver_bitbucket, get_permission_resolver_confluence,
+    get_permission_resolver_jira, get_permission_resolver_jira_any,
+    get_permission_resolver_jira_service_management, get_permission_resolver_jira_software,
 };
 use glob::glob;
 use std::{
@@ -420,7 +419,6 @@ pub(crate) fn scan_directory<'a>(
     let (confluence_permission_resolver, confluence_regex_map) =
         get_permission_resolver_confluence();
     let (bitbucket_permission_resolver, bitbucket_regex_map) = get_permission_resolver_bitbucket();
-    let (compass_permission_resolver, compass_regex_map) = get_permission_resolver_compass();
 
     let mut definition_analysis_interp = Interp::<DefinitionAnalysisRunner>::new(
         &proj.env,
@@ -439,8 +437,6 @@ pub(crate) fn scan_directory<'a>(
         &confluence_regex_map,
         &bitbucket_permission_resolver,
         &bitbucket_regex_map,
-        &compass_permission_resolver,
-        &compass_regex_map,
     );
 
     let mut interp = Interp::new(
@@ -460,8 +456,6 @@ pub(crate) fn scan_directory<'a>(
         &confluence_regex_map,
         &bitbucket_permission_resolver,
         &bitbucket_regex_map,
-        &compass_permission_resolver,
-        &compass_regex_map,
     );
     let mut authn_interp = Interp::new(
         &proj.env,
@@ -480,8 +474,6 @@ pub(crate) fn scan_directory<'a>(
         &confluence_regex_map,
         &bitbucket_permission_resolver,
         &bitbucket_regex_map,
-        &compass_permission_resolver,
-        &compass_regex_map,
     );
 
     let mut reporter = Reporter::new();
@@ -502,8 +494,6 @@ pub(crate) fn scan_directory<'a>(
         &confluence_regex_map,
         &bitbucket_permission_resolver,
         &bitbucket_regex_map,
-        &compass_permission_resolver,
-        &compass_regex_map,
     );
     reporter.add_app(opts.appkey.clone().unwrap_or_default(), name.to_owned());
 
@@ -524,8 +514,6 @@ pub(crate) fn scan_directory<'a>(
         &confluence_regex_map,
         &bitbucket_permission_resolver,
         &bitbucket_regex_map,
-        &compass_permission_resolver,
-        &compass_regex_map,
     );
     for func in &proj.funcs {
         let mut def_checker = DefinitionAnalysisRunner::new();