Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

7z support #54

Closed
atlanticaccent opened this issue Jun 14, 2021 · 2 comments · Fixed by #78
Closed

7z support #54

atlanticaccent opened this issue Jun 14, 2021 · 2 comments · Fixed by #78
Labels
hard This issue will likely need intimate knowledge of the project or its dependencies help wanted Extra attention is needed
Milestone
0.4.x

Comments

@atlanticaccent
Copy link
Owner

compress-tools claims to support 7z files, but somethings seems to be going wrong there because my tests (on WSL) don't work, and it's not useable on Windows anywany.

Using the cxx crate, we may be able to either:

  • build our own wrapper around the most basic libarchive functions (ew, but necessary for linux, as demonstrated in the next point)
  • include the 7zip DLL and a wrapper around it, which gives us fantastically improved archive capabilities, but only on windows.
@atlanticaccent atlanticaccent added hard This issue will likely need intimate knowledge of the project or its dependencies help wanted Extra attention is needed labels Jun 14, 2021
@atlanticaccent
Copy link
Owner Author

atlanticaccent commented Aug 18, 2021 •
edited
Loading

Another option:

Use the XADMaster Obj-C library built for 'The Unarchiver' :

And a crate for Obj-C bindings:

@jaghaimo
Copy link

Poor-mans solution is a solution as well. Require the user to provide 7z executable (autodetect and call as external program).

@atlanticaccent atlanticaccent added this to the 0.4.0 milestone Aug 23, 2021
@atlanticaccent atlanticaccent mentioned this issue Aug 23, 2021
Merged
atlanticaccent added a commit that referenced this issue Aug 23, 2021
@atlanticaccent
Merge pull request #78 from atlanticaccent/install_refactor
1b5463a 
Rewrite installation functionality

- Support wider range of archive formats (ie: 7z)
- Improve parallelism of multi-archive installs
- Support replacing symlinked mods
- Preserve mod folder names on replace

Closes #75, closes #72, closes #71, closes #54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hard This issue will likely need intimate knowledge of the project or its dependencies help wanted Extra attention is needed
Projects
None yet
Milestone
0.4.x
Development

Successfully merging a pull request may close this issue.

Rewrite installation functionality atlanticaccent/starsector-mod-manager-rust
2 participants
@jaghaimo @atlanticaccent