Book: naming convention for loop functions

[kachayev]

There are quite a few functions in the book that runs while loop inside as are supposed to be called instead task::spawn. E.g. server, client, client_writer. I think it makes sense to extend those name to explicitly set expectation on loop inside it, like server_loop, client_loop, client_writer_loop. Would be happy to provide PR if that sounds like a helpful change.

Another thought about naming, client function technically is not about "client", it's about "connection". Maybe it should be connection_loop? It makes disconnect handling easier to read.

[skade]

We spoke about his after the course and I agree, I think calling the functions loop makes sense. /cc @matklad

[matklad]

+1

I'd think for server a more specif accept_look might work better.

[matklad]

@kachayev are you still willing to provide a pull request? ;)

[kachayev]

@matklad Absolutely! ;) Will submit PR shortly.

[skade]

@kachayev please also submit one to async-rs/a-chat, it's the reference implementation.