Fixed most of clippy's warnings

Author: dssgabriel

interpol-rs/src/interpol.rs

@@ -45,8 +45,8 @@ pub trait Register: Send + Sync {
 #[macro_export]
 macro_rules! impl_register {
     ($t:ty) => {
-        use crate::interpol::Register;
         use std::collections::TryReserveError;
+        use $crate::interpol::Register;
 
         #[typetag::serde]
         impl Register for $t {
@@ -57,7 +57,7 @@ macro_rules! impl_register {
                 Ok(())
             }
 
-            fn tsc(&self) -> crate::types::Tsc {
+            fn tsc(&self) -> $crate::types::Tsc {
                 self.tsc
             }
         }
@@ -117,18 +117,14 @@ fn serialize(
     println!("[interpol]: serializing traces for rank {current_rank}");
     let ser_traces = serde_json::to_string_pretty(events)
         .expect("failed to serialize vector contents to string");
-    let filename = format!(
-        "{}/rank{}_traces.json",
-        INTERPOL_DIR,
-        current_rank.to_string()
-    );
+    let filename = format!("{}/rank{}_traces.json", INTERPOL_DIR, current_rank);
 
     fs::create_dir_all(INTERPOL_DIR)?;
     let mut file = File::options()
         .write(true)
         .truncate(true)
         .create(true)
-        .open(filename.clone())?;
+        .open(filename)?;
     write!(file, "{}", ser_traces)?;
     Ok(())
 }

interpol-rs/src/lib.rs

@@ -52,7 +52,7 @@ impl From<std::collections::TryReserveError> for InterpolError {
 #[macro_export]
 macro_rules! impl_builder_error {
     ($t:ty) => {
-        use crate::{InterpolError, InterpolErrorKind};
+        use $crate::{InterpolError, InterpolErrorKind};
 
         impl From<$t> for InterpolError {
             fn from(error: $t) -> Self {

interpol-rs/src/mpi_events/collectives/mpi_ibcast.rs

@@ -14,7 +14,7 @@ use serde::{Deserialize, Serialize};
 /// - the tag of the communication;
 /// - the current value of the Time Stamp counter before the call to `MPI_Ibcast`.
 /// - the duration of the call.
-#[derive(Builder, Clone, Debug, PartialEq, Serialize, Deserialize)]
+#[derive(Builder, Clone, Debug, PartialEq, Eq, Serialize, Deserialize)]
 pub struct MpiIbcast {
     current_rank: MpiRank,
     partner_rank: MpiRank,

interpol-rs/src/mpi_events/collectives/mpi_igather.rs

@@ -15,7 +15,7 @@ use serde::{Deserialize, Serialize};
 /// - the tag of the communication;
 /// - the current value of the Time Stamp counter before the call to `MPI_Igather`.
 /// - the duration of the call.
-#[derive(Builder, Clone, Debug, PartialEq, Serialize, Deserialize)]
+#[derive(Builder, Clone, Debug, PartialEq, Eq, Serialize, Deserialize)]
 pub struct MpiIgather {
     current_rank: MpiRank,
     partner_rank: MpiRank,

interpol-rs/src/mpi_events/collectives/mpi_ireduce.rs

@@ -15,7 +15,7 @@ use serde::{Deserialize, Serialize};
 /// - the tag of the communication;
 /// - the current value of the Time Stamp counter before the call to `MPI_Ireduce`.
 /// - the duration of the call.
-#[derive(Builder, Clone, Debug, PartialEq, Serialize, Deserialize)]
+#[derive(Builder, Clone, Debug, PartialEq, Eq, Serialize, Deserialize)]
 pub struct MpiIreduce {
     current_rank: MpiRank,
     partner_rank: MpiRank,

interpol-rs/src/mpi_events/collectives/mpi_iscatter.rs

@@ -15,7 +15,7 @@ use serde::{Deserialize, Serialize};
 /// - the tag of the communication;
 /// - the current value of the Time Stamp counter before the call to `MPI_Iscatter`.
 /// - the duration of the call.
-#[derive(Builder, Clone, Debug, PartialEq, Serialize, Deserialize)]
+#[derive(Builder, Clone, Debug, PartialEq, Eq, Serialize, Deserialize)]
 pub struct MpiIscatter {
     current_rank: MpiRank,
     partner_rank: MpiRank,

interpol-rs/src/mpi_events/point_to_point/mpi_irecv.rs

@@ -15,7 +15,7 @@ use serde::{Deserialize, Serialize};
 /// - the duration of the call.
 /// The TSC is measured using the `rdtscp` and `lfence` instructions (see Intel documentation for
 /// further information).
-#[derive(Builder, Clone, Debug, PartialEq, Serialize, Deserialize)]
+#[derive(Builder, Clone, Debug, PartialEq, Eq, Serialize, Deserialize)]
 pub struct MpiIrecv {
     current_rank: MpiRank,
     partner_rank: MpiRank,

interpol-rs/src/mpi_events/point_to_point/mpi_isend.rs

@@ -15,7 +15,7 @@ use serde::{Deserialize, Serialize};
 /// - the duration of the call.
 /// The TSC is measured using the `rdtscp` and `lfence` instructions (see Intel documentation for
 /// further information).
-#[derive(Builder, Clone, Debug, PartialEq, Serialize, Deserialize)]
+#[derive(Builder, Clone, Debug, PartialEq, Eq, Serialize, Deserialize)]
 pub struct MpiIsend {
     current_rank: MpiRank,
     partner_rank: MpiRank,

interpol-rs/src/mpi_events/point_to_point/mpi_recv.rs

@@ -16,7 +16,7 @@ use serde::{Deserialize, Serialize};
 /// - the duration of the call.
 /// The TSC is measured using the `rdtscp` and `lfence` instructions (see Intel documentation for
 /// further information).
-#[derive(Builder, Clone, Debug, PartialEq, Serialize, Deserialize)]
+#[derive(Builder, Clone, Debug, PartialEq, Eq, Serialize, Deserialize)]
 pub struct MpiRecv {
     current_rank: MpiRank,
     partner_rank: MpiRank,

interpol-rs/src/mpi_events/point_to_point/mpi_send.rs

@@ -16,7 +16,7 @@ use serde::{Deserialize, Serialize};
 /// - the duration of the call.
 /// The TSC is measured using the `rdtscp` and `lfence` instructions (see Intel documentation for
 /// further information).
-#[derive(Builder, Clone, Debug, PartialEq, Serialize, Deserialize)]
+#[derive(Builder, Clone, Debug, PartialEq, Eq, Serialize, Deserialize)]
 pub struct MpiSend {
     current_rank: MpiRank,
     partner_rank: MpiRank,

interpol-rs/src/mpi_events/synchronization/mpi_barrier.rs

@@ -12,7 +12,7 @@ use serde::{Deserialize, Serialize};
 /// - the duration of the call.
 /// The TSC is measured using the `rdtscp` and `lfence` instructions (see Intel documentation for
 /// further information).
-#[derive(Builder, Clone, Debug, PartialEq, Serialize, Deserialize)]
+#[derive(Builder, Clone, Debug, PartialEq, Eq, Serialize, Deserialize)]
 pub struct MpiBarrier {
     current_rank: MpiRank,
     comm: MpiComm,

interpol-rs/src/mpi_events/synchronization/mpi_ibarrier.rs

@@ -13,7 +13,7 @@ use serde::{Deserialize, Serialize};
 /// - the duration of the call.
 /// The TSC is measured using the `rdtscp` and `lfence` instructions (see Intel documentation for
 /// further information).
-#[derive(Builder, Clone, Debug, PartialEq, Serialize, Deserialize)]
+#[derive(Builder, Clone, Debug, PartialEq, Eq, Serialize, Deserialize)]
 pub struct MpiIbarrier {
     current_rank: MpiRank,
     comm: MpiComm,

interpol-rs/src/mpi_events/synchronization/mpi_test.rs

@@ -13,7 +13,7 @@ use serde::{Deserialize, Serialize};
 /// - the duration of the call.
 /// The TSC is measured using the `rdtscp` and `lfence` instructions (see Intel documentation for
 /// further information).
-#[derive(Builder, Clone, Debug, PartialEq, Serialize, Deserialize)]
+#[derive(Builder, Clone, Debug, PartialEq, Eq, Serialize, Deserialize)]
 pub struct MpiTest {
     current_rank: MpiRank,
     req: MpiReq,

interpol-rs/src/mpi_events/synchronization/mpi_wait.rs

@@ -12,7 +12,7 @@ use serde::{Deserialize, Serialize};
 /// - the duration of the call.
 /// The TSC is measured using the `rdtscp` and `lfence` instructions (see Intel documentation for
 /// further information).
-#[derive(Builder, Clone, Debug, PartialEq, Serialize, Deserialize)]
+#[derive(Builder, Clone, Debug, PartialEq, Eq, Serialize, Deserialize)]
 pub struct MpiWait {
     current_rank: MpiRank,
     req: MpiReq,

interpol-rs/src/types.rs

@@ -10,7 +10,7 @@ pub type MpiTag = i32;
 pub type Tsc = u64;
 pub type Usecs = f64;
 
-#[derive(Debug, PartialEq)]
+#[derive(Debug, PartialEq, Eq)]
 #[repr(i8)]
 pub enum MpiCallType {
     Init,
@@ -30,7 +30,7 @@ pub enum MpiCallType {
     Iscatter,
 }
 
-#[derive(Debug, Clone, PartialEq, Serialize, Deserialize)]
+#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
 #[repr(i8)]
 pub enum MpiOp {
     Opnull,