PreSign request (#341)

jderusse · web-flow · commit eb6ded6431c6 · 2020-03-22T13:14:52.000+01:00
* Draft PreSign request

* Add documentation

* Implement Presign in Signers

* Regenerate Inputs

* Refactor signer

* Fix compare aligment

* Add RequestContext

* Add SDK tests

* Typehint with DatetimeInterface

* Remove presign override in s3

* Use memory first for RewindableFallback

* Add comment on internal use of RewindableStream

* Close stream and fix typehint

* Fix treshold size
diff --git a/src/DynamoDbClient.php b/src/DynamoDbClient.php
@@ -3,6 +3,7 @@
 namespace AsyncAws\DynamoDb;
 
 use AsyncAws\Core\AbstractApi;
+use AsyncAws\Core\RequestContext;
 use AsyncAws\DynamoDb\Input\CreateTableInput;
 use AsyncAws\DynamoDb\Input\DeleteItemInput;
 use AsyncAws\DynamoDb\Input\DeleteTableInput;
@@ -51,7 +52,7 @@ class DynamoDbClient extends AbstractApi
      */
     public function createTable($input): CreateTableOutput
     {
-        $response = $this->getResponse(CreateTableInput::create($input)->request());
+        $response = $this->getResponse(CreateTableInput::create($input)->request(), new RequestContext(['operation' => 'CreateTable']));
 
         return new CreateTableOutput($response);
     }
@@ -77,7 +78,7 @@ public function createTable($input): CreateTableOutput
      */
     public function deleteItem($input): DeleteItemOutput
     {
-        $response = $this->getResponse(DeleteItemInput::create($input)->request());
+        $response = $this->getResponse(DeleteItemInput::create($input)->request(), new RequestContext(['operation' => 'DeleteItem']));
 
         return new DeleteItemOutput($response);
     }
@@ -97,7 +98,7 @@ public function deleteItem($input): DeleteItemOutput
      */
     public function deleteTable($input): DeleteTableOutput
     {
-        $response = $this->getResponse(DeleteTableInput::create($input)->request());
+        $response = $this->getResponse(DeleteTableInput::create($input)->request(), new RequestContext(['operation' => 'DeleteTable']));
 
         return new DeleteTableOutput($response);
     }
@@ -114,7 +115,7 @@ public function deleteTable($input): DeleteTableOutput
      */
     public function describeTable($input): DescribeTableOutput
     {
-        $response = $this->getResponse(DescribeTableInput::create($input)->request());
+        $response = $this->getResponse(DescribeTableInput::create($input)->request(), new RequestContext(['operation' => 'DescribeTable']));
 
         return new DescribeTableOutput($response);
     }
@@ -137,7 +138,7 @@ public function describeTable($input): DescribeTableOutput
      */
     public function getItem($input): GetItemOutput
     {
-        $response = $this->getResponse(GetItemInput::create($input)->request());
+        $response = $this->getResponse(GetItemInput::create($input)->request(), new RequestContext(['operation' => 'GetItem']));
 
         return new GetItemOutput($response);
     }
@@ -156,7 +157,7 @@ public function getItem($input): GetItemOutput
     public function listTables($input = []): ListTablesOutput
     {
         $input = ListTablesInput::create($input);
-        $response = $this->getResponse($input->request());
+        $response = $this->getResponse($input->request(), new RequestContext(['operation' => 'ListTables']));
 
         return new ListTablesOutput($response, $this, $input);
     }
@@ -185,7 +186,7 @@ public function listTables($input = []): ListTablesOutput
      */
     public function putItem($input): PutItemOutput
     {
-        $response = $this->getResponse(PutItemInput::create($input)->request());
+        $response = $this->getResponse(PutItemInput::create($input)->request(), new RequestContext(['operation' => 'PutItem']));
 
         return new PutItemOutput($response);
     }
@@ -219,7 +220,7 @@ public function putItem($input): PutItemOutput
     public function query($input): QueryOutput
     {
         $input = QueryInput::create($input);
-        $response = $this->getResponse($input->request());
+        $response = $this->getResponse($input->request(), new RequestContext(['operation' => 'Query']));
 
         return new QueryOutput($response, $this, $input);
     }
@@ -252,7 +253,7 @@ public function query($input): QueryOutput
     public function scan($input): ScanOutput
     {
         $input = ScanInput::create($input);
-        $response = $this->getResponse($input->request());
+        $response = $this->getResponse($input->request(), new RequestContext(['operation' => 'Scan']));
 
         return new ScanOutput($response, $this, $input);
     }
@@ -269,7 +270,7 @@ public function scan($input): ScanOutput
     public function tableExists($input): TableExistsWaiter
     {
         $input = DescribeTableInput::create($input);
-        $response = $this->getResponse($input->request());
+        $response = $this->getResponse($input->request(), new RequestContext(['operation' => 'DescribeTable']));
 
         return new TableExistsWaiter($response, $this, $input);
     }
@@ -286,7 +287,7 @@ public function tableExists($input): TableExistsWaiter
     public function tableNotExists($input): TableNotExistsWaiter
     {
         $input = DescribeTableInput::create($input);
-        $response = $this->getResponse($input->request());
+        $response = $this->getResponse($input->request(), new RequestContext(['operation' => 'DescribeTable']));
 
         return new TableNotExistsWaiter($response, $this, $input);
     }
@@ -316,7 +317,7 @@ public function tableNotExists($input): TableNotExistsWaiter
      */
     public function updateItem($input): UpdateItemOutput
     {
-        $response = $this->getResponse(UpdateItemInput::create($input)->request());
+        $response = $this->getResponse(UpdateItemInput::create($input)->request(), new RequestContext(['operation' => 'UpdateItem']));
 
         return new UpdateItemOutput($response);
     }
@@ -340,7 +341,7 @@ public function updateItem($input): UpdateItemOutput
      */
     public function updateTable($input): UpdateTableOutput
     {
-        $response = $this->getResponse(UpdateTableInput::create($input)->request());
+        $response = $this->getResponse(UpdateTableInput::create($input)->request(), new RequestContext(['operation' => 'UpdateTable']));
 
         return new UpdateTableOutput($response);
     }
diff --git a/src/Input/CreateTableInput.php b/src/Input/CreateTableInput.php
@@ -3,6 +3,7 @@
 namespace AsyncAws\DynamoDb\Input;
 
 use AsyncAws\Core\Exception\InvalidArgument;
+use AsyncAws\Core\Input;
 use AsyncAws\Core\Request;
 use AsyncAws\Core\Stream\StreamFactory;
 use AsyncAws\DynamoDb\Enum\BillingMode;
@@ -15,7 +16,7 @@
 use AsyncAws\DynamoDb\ValueObject\StreamSpecification;
 use AsyncAws\DynamoDb\ValueObject\Tag;
 
-class CreateTableInput
+class CreateTableInput implements Input
 {
     /**
      * An array of attributes that describe the key schema for the table and indexes.
diff --git a/src/Input/DeleteItemInput.php b/src/Input/DeleteItemInput.php
@@ -3,6 +3,7 @@
 namespace AsyncAws\DynamoDb\Input;
 
 use AsyncAws\Core\Exception\InvalidArgument;
+use AsyncAws\Core\Input;
 use AsyncAws\Core\Request;
 use AsyncAws\Core\Stream\StreamFactory;
 use AsyncAws\DynamoDb\Enum\ConditionalOperator;
@@ -12,7 +13,7 @@
 use AsyncAws\DynamoDb\ValueObject\AttributeValue;
 use AsyncAws\DynamoDb\ValueObject\ExpectedAttributeValue;
 
-class DeleteItemInput
+class DeleteItemInput implements Input
 {
     /**
      * The name of the table from which to delete the item.
diff --git a/src/Input/DeleteTableInput.php b/src/Input/DeleteTableInput.php
@@ -3,10 +3,11 @@
 namespace AsyncAws\DynamoDb\Input;
 
 use AsyncAws\Core\Exception\InvalidArgument;
+use AsyncAws\Core\Input;
 use AsyncAws\Core\Request;
 use AsyncAws\Core\Stream\StreamFactory;
 
-class DeleteTableInput
+class DeleteTableInput implements Input
 {
     /**
      * The name of the table to delete.
diff --git a/src/Input/DescribeTableInput.php b/src/Input/DescribeTableInput.php
@@ -3,10 +3,11 @@
 namespace AsyncAws\DynamoDb\Input;
 
 use AsyncAws\Core\Exception\InvalidArgument;
+use AsyncAws\Core\Input;
 use AsyncAws\Core\Request;
 use AsyncAws\Core\Stream\StreamFactory;
 
-class DescribeTableInput
+class DescribeTableInput implements Input
 {
     /**
      * The name of the table to describe.
diff --git a/src/Input/GetItemInput.php b/src/Input/GetItemInput.php
@@ -3,12 +3,13 @@
 namespace AsyncAws\DynamoDb\Input;
 
 use AsyncAws\Core\Exception\InvalidArgument;
+use AsyncAws\Core\Input;
 use AsyncAws\Core\Request;
 use AsyncAws\Core\Stream\StreamFactory;
 use AsyncAws\DynamoDb\Enum\ReturnConsumedCapacity;
 use AsyncAws\DynamoDb\ValueObject\AttributeValue;
 
-class GetItemInput
+class GetItemInput implements Input
 {
     /**
      * The name of the table containing the requested item.
diff --git a/src/Input/ListTablesInput.php b/src/Input/ListTablesInput.php
@@ -2,10 +2,11 @@
 
 namespace AsyncAws\DynamoDb\Input;
 
+use AsyncAws\Core\Input;
 use AsyncAws\Core\Request;
 use AsyncAws\Core\Stream\StreamFactory;
 
-class ListTablesInput
+class ListTablesInput implements Input
 {
     /**
      * The first table name that this operation will evaluate. Use the value that was returned for `LastEvaluatedTableName`
diff --git a/src/Input/PutItemInput.php b/src/Input/PutItemInput.php
@@ -3,6 +3,7 @@
 namespace AsyncAws\DynamoDb\Input;
 
 use AsyncAws\Core\Exception\InvalidArgument;
+use AsyncAws\Core\Input;
 use AsyncAws\Core\Request;
 use AsyncAws\Core\Stream\StreamFactory;
 use AsyncAws\DynamoDb\Enum\ConditionalOperator;
@@ -12,7 +13,7 @@
 use AsyncAws\DynamoDb\ValueObject\AttributeValue;
 use AsyncAws\DynamoDb\ValueObject\ExpectedAttributeValue;
 
-class PutItemInput
+class PutItemInput implements Input
 {
     /**
      * The name of the table to contain the item.
diff --git a/src/Input/QueryInput.php b/src/Input/QueryInput.php
@@ -3,6 +3,7 @@
 namespace AsyncAws\DynamoDb\Input;
 
 use AsyncAws\Core\Exception\InvalidArgument;
+use AsyncAws\Core\Input;
 use AsyncAws\Core\Request;
 use AsyncAws\Core\Stream\StreamFactory;
 use AsyncAws\DynamoDb\Enum\ConditionalOperator;
@@ -11,7 +12,7 @@
 use AsyncAws\DynamoDb\ValueObject\AttributeValue;
 use AsyncAws\DynamoDb\ValueObject\Condition;
 
-class QueryInput
+class QueryInput implements Input
 {
     /**
      * The name of the table containing the requested items.
diff --git a/src/Input/ScanInput.php b/src/Input/ScanInput.php
@@ -3,6 +3,7 @@
 namespace AsyncAws\DynamoDb\Input;
 
 use AsyncAws\Core\Exception\InvalidArgument;
+use AsyncAws\Core\Input;
 use AsyncAws\Core\Request;
 use AsyncAws\Core\Stream\StreamFactory;
 use AsyncAws\DynamoDb\Enum\ConditionalOperator;
@@ -11,7 +12,7 @@
 use AsyncAws\DynamoDb\ValueObject\AttributeValue;
 use AsyncAws\DynamoDb\ValueObject\Condition;
 
-class ScanInput
+class ScanInput implements Input
 {
     /**
      * The name of the table containing the requested items; or, if you provide `IndexName`, the name of the table to which
diff --git a/src/Input/UpdateItemInput.php b/src/Input/UpdateItemInput.php
@@ -3,6 +3,7 @@
 namespace AsyncAws\DynamoDb\Input;
 
 use AsyncAws\Core\Exception\InvalidArgument;
+use AsyncAws\Core\Input;
 use AsyncAws\Core\Request;
 use AsyncAws\Core\Stream\StreamFactory;
 use AsyncAws\DynamoDb\Enum\ConditionalOperator;
@@ -13,7 +14,7 @@
 use AsyncAws\DynamoDb\ValueObject\AttributeValueUpdate;
 use AsyncAws\DynamoDb\ValueObject\ExpectedAttributeValue;
 
-class UpdateItemInput
+class UpdateItemInput implements Input
 {
     /**
      * The name of the table containing the item to update.
diff --git a/src/Input/UpdateTableInput.php b/src/Input/UpdateTableInput.php
@@ -3,6 +3,7 @@
 namespace AsyncAws\DynamoDb\Input;
 
 use AsyncAws\Core\Exception\InvalidArgument;
+use AsyncAws\Core\Input;
 use AsyncAws\Core\Request;
 use AsyncAws\Core\Stream\StreamFactory;
 use AsyncAws\DynamoDb\Enum\BillingMode;
@@ -13,7 +14,7 @@
 use AsyncAws\DynamoDb\ValueObject\SSESpecification;
 use AsyncAws\DynamoDb\ValueObject\StreamSpecification;
 
-class UpdateTableInput
+class UpdateTableInput implements Input
 {
     /**
      * An array of attributes that describe the key schema for the table and indexes. If you are adding a new global

Original file line number	Diff line number	Diff line change
`@@ -3,6 +3,7 @@`
`3`	`3`	`namespace AsyncAws\DynamoDb;`
`4`	`4`
`5`	`5`	`use AsyncAws\Core\AbstractApi;`
	`6`	`+use AsyncAws\Core\RequestContext;`
`6`	`7`	`use AsyncAws\DynamoDb\Input\CreateTableInput;`
`7`	`8`	`use AsyncAws\DynamoDb\Input\DeleteItemInput;`
`8`	`9`	`use AsyncAws\DynamoDb\Input\DeleteTableInput;`
`@@ -51,7 +52,7 @@ class DynamoDbClient extends AbstractApi`
`51`	`52`	`*/`
`52`	`53`	`public function createTable($input): CreateTableOutput`
`53`	`54`	`{`
`54`		`- $response = $this->getResponse(CreateTableInput::create($input)->request());`
	`55`	`+ $response = $this->getResponse(CreateTableInput::create($input)->request(), new RequestContext(['operation' => 'CreateTable']));`
`55`	`56`
`56`	`57`	`return new CreateTableOutput($response);`
`57`	`58`	`}`
`@@ -77,7 +78,7 @@ public function createTable($input): CreateTableOutput`
`77`	`78`	`*/`
`78`	`79`	`public function deleteItem($input): DeleteItemOutput`
`79`	`80`	`{`
`80`		`- $response = $this->getResponse(DeleteItemInput::create($input)->request());`
	`81`	`+ $response = $this->getResponse(DeleteItemInput::create($input)->request(), new RequestContext(['operation' => 'DeleteItem']));`
`81`	`82`
`82`	`83`	`return new DeleteItemOutput($response);`
`83`	`84`	`}`
`@@ -97,7 +98,7 @@ public function deleteItem($input): DeleteItemOutput`
`97`	`98`	`*/`
`98`	`99`	`public function deleteTable($input): DeleteTableOutput`
`99`	`100`	`{`
`100`		`- $response = $this->getResponse(DeleteTableInput::create($input)->request());`
	`101`	`+ $response = $this->getResponse(DeleteTableInput::create($input)->request(), new RequestContext(['operation' => 'DeleteTable']));`
`101`	`102`
`102`	`103`	`return new DeleteTableOutput($response);`
`103`	`104`	`}`
`@@ -114,7 +115,7 @@ public function deleteTable($input): DeleteTableOutput`
`114`	`115`	`*/`
`115`	`116`	`public function describeTable($input): DescribeTableOutput`
`116`	`117`	`{`
`117`		`- $response = $this->getResponse(DescribeTableInput::create($input)->request());`
	`118`	`+ $response = $this->getResponse(DescribeTableInput::create($input)->request(), new RequestContext(['operation' => 'DescribeTable']));`
`118`	`119`
`119`	`120`	`return new DescribeTableOutput($response);`
`120`	`121`	`}`
`@@ -137,7 +138,7 @@ public function describeTable($input): DescribeTableOutput`
`137`	`138`	`*/`
`138`	`139`	`public function getItem($input): GetItemOutput`
`139`	`140`	`{`
`140`		`- $response = $this->getResponse(GetItemInput::create($input)->request());`
	`141`	`+ $response = $this->getResponse(GetItemInput::create($input)->request(), new RequestContext(['operation' => 'GetItem']));`
`141`	`142`
`142`	`143`	`return new GetItemOutput($response);`
`143`	`144`	`}`
`@@ -156,7 +157,7 @@ public function getItem($input): GetItemOutput`
`156`	`157`	`public function listTables($input = []): ListTablesOutput`
`157`	`158`	`{`
`158`	`159`	`$input = ListTablesInput::create($input);`
`159`		`- $response = $this->getResponse($input->request());`
	`160`	`+ $response = $this->getResponse($input->request(), new RequestContext(['operation' => 'ListTables']));`
`160`	`161`
`161`	`162`	`return new ListTablesOutput($response, $this, $input);`
`162`	`163`	`}`
`@@ -185,7 +186,7 @@ public function listTables($input = []): ListTablesOutput`
`185`	`186`	`*/`
`186`	`187`	`public function putItem($input): PutItemOutput`
`187`	`188`	`{`
`188`		`- $response = $this->getResponse(PutItemInput::create($input)->request());`
	`189`	`+ $response = $this->getResponse(PutItemInput::create($input)->request(), new RequestContext(['operation' => 'PutItem']));`
`189`	`190`
`190`	`191`	`return new PutItemOutput($response);`
`191`	`192`	`}`
`@@ -219,7 +220,7 @@ public function putItem($input): PutItemOutput`
`219`	`220`	`public function query($input): QueryOutput`
`220`	`221`	`{`
`221`	`222`	`$input = QueryInput::create($input);`
`222`		`- $response = $this->getResponse($input->request());`
	`223`	`+ $response = $this->getResponse($input->request(), new RequestContext(['operation' => 'Query']));`
`223`	`224`
`224`	`225`	`return new QueryOutput($response, $this, $input);`
`225`	`226`	`}`
`@@ -252,7 +253,7 @@ public function query($input): QueryOutput`
`252`	`253`	`public function scan($input): ScanOutput`
`253`	`254`	`{`
`254`	`255`	`$input = ScanInput::create($input);`
`255`		`- $response = $this->getResponse($input->request());`
	`256`	`+ $response = $this->getResponse($input->request(), new RequestContext(['operation' => 'Scan']));`
`256`	`257`
`257`	`258`	`return new ScanOutput($response, $this, $input);`
`258`	`259`	`}`
`@@ -269,7 +270,7 @@ public function scan($input): ScanOutput`
`269`	`270`	`public function tableExists($input): TableExistsWaiter`
`270`	`271`	`{`
`271`	`272`	`$input = DescribeTableInput::create($input);`
`272`		`- $response = $this->getResponse($input->request());`
	`273`	`+ $response = $this->getResponse($input->request(), new RequestContext(['operation' => 'DescribeTable']));`
`273`	`274`
`274`	`275`	`return new TableExistsWaiter($response, $this, $input);`
`275`	`276`	`}`
`@@ -286,7 +287,7 @@ public function tableExists($input): TableExistsWaiter`
`286`	`287`	`public function tableNotExists($input): TableNotExistsWaiter`
`287`	`288`	`{`
`288`	`289`	`$input = DescribeTableInput::create($input);`
`289`		`- $response = $this->getResponse($input->request());`
	`290`	`+ $response = $this->getResponse($input->request(), new RequestContext(['operation' => 'DescribeTable']));`
`290`	`291`
`291`	`292`	`return new TableNotExistsWaiter($response, $this, $input);`
`292`	`293`	`}`
`@@ -316,7 +317,7 @@ public function tableNotExists($input): TableNotExistsWaiter`
`316`	`317`	`*/`
`317`	`318`	`public function updateItem($input): UpdateItemOutput`
`318`	`319`	`{`
`319`		`- $response = $this->getResponse(UpdateItemInput::create($input)->request());`
	`320`	`+ $response = $this->getResponse(UpdateItemInput::create($input)->request(), new RequestContext(['operation' => 'UpdateItem']));`
`320`	`321`
`321`	`322`	`return new UpdateItemOutput($response);`
`322`	`323`	`}`
`@@ -340,7 +341,7 @@ public function updateItem($input): UpdateItemOutput`
`340`	`341`	`*/`
`341`	`342`	`public function updateTable($input): UpdateTableOutput`
`342`	`343`	`{`
`343`		`- $response = $this->getResponse(UpdateTableInput::create($input)->request());`
	`344`	`+ $response = $this->getResponse(UpdateTableInput::create($input)->request(), new RequestContext(['operation' => 'UpdateTable']));`
`344`	`345`
`345`	`346`	`return new UpdateTableOutput($response);`
`346`	`347`	`}`