Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit 51ff2bc

Browse files
authoredOct 27, 2023
Improve the makefile setup (#1597)
* Remove containers when stopping them This ensures that starting the setup again picks up the new version of the image during the next run. * Clean docker setups in components The components should be pulling the images they launch and not a different tag. And they should not try to start the shared localstack container when the image they use is not localstack. Instead, the should check for the shared container created by the root Makefile * Clean all docker images of the root Makefile * Change the root Makefile to be consistent with services Instead of having `make stop-docker` triggering the `clean` command (which also triggers the cleaning of sub-services), it is now `clean` which depends on `stop-docker` of the root repo. This brings consistency with initialization commands. We now have a symmetry between `initialize`/`clean` and `start-docker`/`stop-docker`.
1 parent b392dcd commit 51ff2bc

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed
 

‎Makefile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,3 +14,4 @@ test: initialize
1414
clean: stop-docker
1515
stop-docker:
1616
docker stop async_aws_localstack-dynamodb || true
17+
docker rm async_aws_localstack-dynamodb || true

0 commit comments

Comments
 (0)
Please sign in to comment.