Fix deprecation for null array offset on PHP 8.5 (#1960)

Author: stof

CHANGELOG.md

@@ -5,6 +5,7 @@
 ### Changed
 
 - Apply no CodingStandard from latest php-cs-fixer.
+- Fix PHP 8.5 deprecation by avoiding using `null` as an array offset.
 
 ### Fixed
 
@@ -15,7 +16,7 @@
 
 ### Fixed
 
-- SignerV4: fix sort of query parameters to build correct canoncal query string
+- SignerV4: fix sort of query parameters to build correct canonical query string
 
 ## 1.27.0
 

src/AbstractApi.php

@@ -324,14 +324,14 @@ private function getDiscoveredEndpoint(string $uri, array $query, ?string $regio
      */
     private function getSigner(?string $region): Signer
     {
-        /** @var string $region */
         $region = $region ?? ($this->configuration->isDefault('region') ? null : $this->configuration->get('region'));
-        if (!isset($this->signers[$region])) {
+        if (!isset($this->signers[$region ?? ''])) {
             $factories = $this->getSignerFactories();
             $factory = null;
             if ($this->configuration->isDefault('endpoint') || $this->configuration->isDefault('region')) {
                 $metadata = $this->getEndpointMetadata($region);
             } else {
+                \assert(null !== $region);
                 // Allow non-aws region with custom endpoint
                 $metadata = $this->getEndpointMetadata(Configuration::DEFAULT_REGION);
                 $metadata['signRegion'] = $region;
@@ -349,10 +349,9 @@ private function getSigner(?string $region): Signer
                 throw new InvalidArgument(\sprintf('None of the signatures "%s" is implemented.', implode(', ', $metadata['signVersions'])));
             }
 
-            $this->signers[$region] = $factory($metadata['signService'], $metadata['signRegion']);
+            $this->signers[$region ?? ''] = $factory($metadata['signService'], $metadata['signRegion']);
         }
 
-        /** @psalm-suppress PossiblyNullArrayOffset */
-        return $this->signers[$region];
+        return $this->signers[$region ?? ''];
     }
 }