Skip to content

Amazon SQS JSON protocol instead of Query protocol #1530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Ferror opened this issue Jul 29, 2023 · 8 comments
Closed

Amazon SQS JSON protocol instead of Query protocol #1530

Ferror opened this issue Jul 29, 2023 · 8 comments

Comments

@Ferror
Copy link
Contributor

Ferror commented Jul 29, 2023

Introduction

This issue is a feature request to represent and maybe an open discussion about such a feature possibility. Amazon says that it should be available only by updating the AWS-SDK version, so for us, I guess it's just specifying the latest API Version when sending the request.

References

@jderusse
Copy link
Member

Actually, the protocol used by async AWS is defined by AWS SDK specs.

So AsyncAws will use JSON as soon as the official SDK will use it.

The first link says that the official php SDK switched to JSON in version 3.269.6 (this is visible here https://github.com/aws/aws-sdk-php/blob/343f7088f246d4667172e69d5f2bf440496bb708/src/data/sqs/2012-11-05/api-2.json#L9)

But they forgot to says that it has been reverted in the following version (see commit aws/aws-sdk-php@6262f18)

I'm not surprised they reverted it, because this is a huge BC break: the JSON protocol is not supported by SQS alternative (or localStack or FakeSqs) which break e2e tests that don't use the real AWS endpoint for dev or tests

@GrahamCampbell
Copy link
Contributor

Yeh, their docs are misleading. You need to downgrade to the specific version they list, rather than upgrade. ;)

@stof
Copy link
Member

stof commented Aug 9, 2023

Yeah, the misleading things in their doc is that "required SDK version" is not a minimum version. It is an exact version.

@Ferror
Copy link
Contributor Author

Ferror commented Nov 10, 2023

@stof
Copy link
Member

stof commented Nov 10, 2023

@Ferror see #1601 where the code switches to the JSON protocol by reflecting the change done in the official PHP SDK. This will come soon in async-aws (we first need to make our CI green for it)

@Ferror
Copy link
Contributor Author

Ferror commented Nov 10, 2023

Let me also relate this issue to the localstack support PR: localstack/localstack#8268

@GrahamCampbell
Copy link
Contributor

This is now available on our sqs package via ^2.0@dev. Though note that you may experience an issue (that I am still looking in to): #1620.

@stof
Copy link
Member

stof commented Feb 2, 2024

I'm closing this issue as async-aws/sqs 2.0 has already been released.

@stof stof closed this as completed Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants