Migrate the testsuite to PHPUnit 11 (#1977)

Author: stof

.github/workflows/ci.yml

@@ -31,8 +31,7 @@ jobs:
       - name: Download dependencies
         run: |
           composer config minimum-stability dev
-          composer req symfony/phpunit-bridge --no-update
           composer update --no-interaction --prefer-dist --optimize-autoloader --prefer-stable
 
       - name: Run tests
-        run: ./vendor/bin/simple-phpunit
+        run: ./vendor/bin/phpunit

Makefile

@@ -5,7 +5,7 @@ start-docker:
 	echo "Noop"
 
 test: initialize
-	./vendor/bin/simple-phpunit
+	./vendor/bin/phpunit
 
 clean: stop-docker
 stop-docker:

composer.json

@@ -17,6 +17,11 @@
         "async-aws/core": "^1.9",
         "symfony/polyfill-uuid": "^1.13.1"
     },
+    "require-dev": {
+        "phpunit/phpunit": "^11.5.42",
+        "symfony/error-handler": "^7.3.2 || ^8.0",
+        "symfony/phpunit-bridge": "^7.3.2 || ^8.0"
+    },
     "autoload": {
         "psr-4": {
             "AsyncAws\\Athena\\": "src"

phpunit.xml.dist

@@ -1,17 +1,22 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-         xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/9.3/phpunit.xsd"
+         xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/11.5/phpunit.xsd"
          backupGlobals="false"
          colors="true"
          bootstrap="vendor/autoload.php"
          failOnRisky="true"
          failOnWarning="true"
+         failOnDeprecation="true"
+         failOnNotice="true"
 >
-  <coverage>
+  <source ignoreSuppressionOfDeprecations="true">
     <include>
       <directory>./src</directory>
     </include>
-  </coverage>
+    <deprecationTrigger>
+      <function>trigger_deprecation</function>
+    </deprecationTrigger>
+  </source>
   <php>
     <ini name="error_reporting" value="-1"/>
   </php>
@@ -20,4 +25,7 @@
       <directory>./tests/</directory>
     </testsuite>
   </testsuites>
+  <extensions>
+    <bootstrap class="Symfony\Bridge\PhpUnit\SymfonyExtension"/>
+  </extensions>
 </phpunit>

tests/Unit/Input/StartCalculationExecutionRequestTest.php

@@ -5,14 +5,11 @@
 use AsyncAws\Athena\Input\StartCalculationExecutionRequest;
 use AsyncAws\Athena\ValueObject\CalculationConfiguration;
 use AsyncAws\Core\Test\TestCase;
+use PHPUnit\Framework\Attributes\IgnoreDeprecations;
 
 class StartCalculationExecutionRequestTest extends TestCase
 {
-    /**
-     * @group legacy
-     *
-     * @expectedDeprecation The property "CalculationConfiguration" of "%s" is deprecated by AWS.
-     */
+    #[IgnoreDeprecations]
     public function testRequest(): void
     {
         $input = new StartCalculationExecutionRequest([
@@ -43,6 +40,8 @@ public function testRequest(): void
 }
                 ';
 
+        $this->expectUserDeprecationMessage('The property "CalculationConfiguration" of "AsyncAws\Athena\Input\StartCalculationExecutionRequest" is deprecated by AWS.');
+
         self::assertRequestEqualsHttpRequest($expected, $input->request());
     }
 }