-
-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Returned wcs header has 100s of header cards added {astrometry.net} #2748
Comments
cc @mwcraig |
Thanks for the ping @bsipocz -- I'll take a look at this tomorrow morning (Friday) along with the open PR for this module. |
@Mucephie -- you are correct that astrometry.net returns a bunch of log information. It isn't clear to me that the default behavior should be to remove them, though -- I've personally never used the log information but was reluctant to delete the cards in case the log was useful to someone. Would it be helpful to have a way to disable adding those? |
@mwcraig It would be very helpful to disable them, or at-least filter out the hundreds of "comment index" entries, and "comment index.fits" entries. A sort of compromise would be to add the astrometry.Net job ID to the fits header so the log could be accessed as needed from the web, or a possible future astroquery/astrometryNet function that takes a job ID and returns the log info if anyone needs to access this information in a pipeline. An example of the URL to grab a full job log is |
@Mucephie Are you looking for just the WCS solution without any additional header arguments? You can get that with, e.g.; from astropy.wcs import WCS
WCS(header).to_header() which will give a header with only WCS-relevant keywords. My take is that astroquery should return all information the online service provides. If it isn't straightforward to remove some of that information, we can provide convenience tools, but we should still make sure users have access to anything the service provides, and I prefer that we provide too much information by default rather than too little. If the problem is that these comment cards are significantly increasing the size of the data being transferred over the internet, though, I could see a case for leaving them out. |
@keflavich This is a potential solution, but I'd much prefer this be a flag in the initial solving call, and have the possibility of adding the job ID to the header by default. And there is some information I'd like to retain that I don't think Internet throughput could be an issue for others who have |
You could always tell it the scale of your image, and then it would use fewer index files and produce fewer header cards ;) |
PS, I was surprised to see that indeed it does not have the original header cards merged in. |
PPS, you can get pixel scale trivially by sqrt(det(CD)) treating CD[12]_[12] as a matrix |
PPPS I filed a ticket to add this merged header as an available output. I am, however, extremely slow at implementing stuff. |
I'm finding that returned solved WCS headers have hundreds of header keys added. Here is an example of the cards numbers:
An example of one of the added keys:
It seems that this behaviour comes from this line in the
monitor_submission
function of the astrometryNet classIts possible that the response text has both, the useful wcs header information, and some unneeded solve log information that then gets parsed into the header.
The text was updated successfully, but these errors were encountered: