Skip to content

Commit 22e8a13

Browse files
committed
Use full variable name
1 parent 5c1b630 commit 22e8a13

File tree

1 file changed

+12
-12
lines changed

1 file changed

+12
-12
lines changed

astroquery/mast/observations.py

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1116,15 +1116,15 @@ def service_request_async(self, service, params, *, pagesize=None, page=None, **
11161116

11171117
return self._portal_api_connection.service_request_async(service, params, pagesize, page, **kwargs)
11181118

1119-
def _normalize_filter_value(self, key: str, val) -> list:
1119+
def _normalize_filter_value(self, key: str, value) -> list:
11201120
"""
11211121
Normalize a filter value into a list suitable for MAST filters.
11221122
11231123
Parameters
11241124
----------
11251125
key : str
11261126
Parameter name (used for error messages).
1127-
val : any
1127+
value : any
11281128
Raw filter value.
11291129
11301130
Returns
@@ -1133,23 +1133,23 @@ def _normalize_filter_value(self, key: str, val) -> list:
11331133
Normalized filter values.
11341134
"""
11351135
# Range filters must be dicts with 'min' and 'max'
1136-
if isinstance(val, dict):
1137-
if not {"min", "max"}.issubset(val.keys()):
1136+
if isinstance(value, dict):
1137+
if not {"min", "max"}.issubset(value.keys()):
11381138
raise InvalidQueryError(
11391139
f'Range filter for "{key}" must be a dictionary with "min" and "max" keys.'
11401140
)
1141-
return [val]
1141+
return [value]
11421142

11431143
# Convert numpy arrays to lists
1144-
if isinstance(val, np.ndarray):
1145-
val = val.tolist()
1144+
if isinstance(value, np.ndarray):
1145+
value = value.tolist()
11461146

11471147
# Convert numpy arrays, sets, or tuples to lists
1148-
if isinstance(val, (set, tuple)):
1149-
val = list(val)
1148+
if isinstance(value, (set, tuple)):
1149+
value = list(value)
11501150

11511151
# Wrap scalars into a list
1152-
return val if isinstance(val, list) else [val]
1152+
return value if isinstance(value, list) else [value]
11531153

11541154
def _build_filters(self, service_params):
11551155
"""
@@ -1166,10 +1166,10 @@ def _build_filters(self, service_params):
11661166
Filters suitable for a MAST filtered query.
11671167
"""
11681168
filters = []
1169-
for key, val in service_params.items():
1169+
for key, value in service_params.items():
11701170
filters.append({
11711171
"paramName": key,
1172-
"values": self._normalize_filter_value(key, val)
1172+
"values": self._normalize_filter_value(key, value)
11731173
})
11741174
return filters
11751175

0 commit comments

Comments
 (0)