-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[async] Evaluate the possiblity of using dbt itself to create the full SQL command #1266
Comments
This issue is stale because it has been open for 30 days with no activity. |
Take into account if we'd be able to solve other related tickets by using this approach: |
DBT Compile
DBT Run
In conclusion, the --empty flag offers a lightweight, dry-run-like behaviour. So we may be able to use it in compile task to generate sql query but if we do this, we must keep in mind that
|
@pankajkoti and I discussed this. 1. Empty Flag in Run Command:
Example with empty
without empty
2. Empty Flag in Run Command to Create Table/View + Compile command to get full query
3. Monkey Patching
We decided to go with option (3) |
Excellent analysis @pankajastro and @pankajkoti - I'm glad we have a way forward. I know monkey patching can be polemic, but I'm optimistic this will allow us to move forward in the async support. |
Context
When implementing #1230, we realised that the
dbt compile
command outputs the select statements related to models and transformations, but not necessarily the remaining relevant parts of the query (including creates, updates, inserts, drops).This logic lives partially in dbt-core code and partially in the dbt adaptors of interest.
Could we leverage the
--empty
flag (dbt-labs/dbt-core#8980 (comment)) in any way?Acceptance criteria
dbt compile
- or somewhere related, to a setup task - to pre-create the full queries that we want to run with the async operators afterwards.The text was updated successfully, but these errors were encountered: