Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on player join when using MySQL database and streaks disabled #122

Open
PlanetTeamSpeakk opened this issue Apr 6, 2021 · 6 comments

Comments

@PlanetTeamSpeakk
Copy link

Whenever a player joins the server, an error is thrown and printed to the console. It doesn't cause any other issues, but should be fixed nonetheless. According to the error message and its stacktrace, it appears that this error is caused by the plugin not checking whether streaks are enabled or not when a player joins. The error in question looks as follows:

[13:42:22 WARN]: [SuperbVote] Plugin SuperbVote v0.5.5 generated an exception while executing task 2503910
java.lang.IllegalArgumentException: streaks not enabled
        at com.google.common.base.Preconditions.checkArgument(Preconditions.java:122) ~[patched_1.16.5.jar:git-Paper-579]
        at io.minimum.minecraft.superbvote.storage.MysqlVoteStorage.getVoteStreak(MysqlVoteStorage.java:369) ~[?:?]
        at io.minimum.minecraft.superbvote.storage.VoteStorage.getVoteStreakIfSupported(VoteStorage.java:25) ~[?:?]
        at io.minimum.minecraft.superbvote.votes.SuperbVoteListener.lambda$onPlayerJoin$4(SuperbVoteListener.java:139) ~[?:?]
        at org.bukkit.craftbukkit.v1_16_R3.scheduler.CraftTask.run(CraftTask.java:100) ~[patched_1.16.5.jar:git-Paper-579]
        at org.bukkit.craftbukkit.v1_16_R3.scheduler.CraftAsyncTask.run(CraftAsyncTask.java:54) ~[patched_1.16.5.jar:git-Paper-579]
        at com.destroystokyo.paper.ServerSchedulerReportingWrapper.run(ServerSchedulerReportingWrapper.java:22) ~[patched_1.16.5.jar:git-Paper-579]
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) [?:?]
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) [?:?]
@BrainStone
Copy link

It would be interesting to know how to enable streaks btw.

The default config contains nothing about it.
Also the streams table can't be renamed!

@100petr
Copy link

100petr commented May 13, 2021

@zachduda
Copy link

Would also like to add that I'm having the same problem with SuperbVote

@BrainStone
Copy link

https://github.com/astei/SuperbVote/wiki/Configuration#if
image

Nothing about what you posted is about streaks.
You posted the docs for the cumulative (aka total) votes.

@100petr
Copy link

100petr commented May 14, 2021

image
and last message and somehow it could be done, but probably the function doesn't work at all, because it gives an error about the database

@viveleroi
Copy link

I'm pretty sure this error has broken our vote rewards from being registered properly. No one has been getting vote rewards after we updated to the version that has this change. Nothing about the streaks appears in our config file, so I can't even turn it on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants