Skip to content

Take inspiration from hamcrest's predicates #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 task
epage opened this issue Mar 28, 2018 · 2 comments
Closed
1 task

Take inspiration from hamcrest's predicates #12

epage opened this issue Mar 28, 2018 · 2 comments
Labels
enhancement Improve the expected

Comments

@epage
Copy link
Contributor

epage commented Mar 28, 2018 •
edited
Loading

See https://github.com/ujh/hamcrest-rust

Predicates in hamcrest not in here include

  • regex match
@epage epage added the enhancement Improve the expected label Mar 28, 2018
epage added a commit to epage/predicates-rs that referenced this issue Apr 1, 2018
@epage
feat(str): Regex predicate
fef5e76 
This is a short term API.  Different issues we'll need to consider when
evolving this include:
- Easy to create predicate
- The ability to customize the regex (e.g. case sensitivity, multi-line,
  ignoring whityespace).
  - It looks like the flags can be enabled with `(?flag)` inside the
    regex. Good enough?
- How error handling should work. Re-export? A single error type for
  the whole crate?

This is a part of assert-rs#12
epage added a commit to epage/predicates-rs that referenced this issue Apr 1, 2018
@epage
feat(str): Regex predicate
f796692 
This is a short term API.  Different issues we'll need to consider when
evolving this include:
- Easy to create predicate
- The ability to customize the regex (e.g. case sensitivity, multi-line,
  ignoring whityespace).
  - It looks like the flags can be enabled with `(?flag)` inside the
    regex. Good enough?
- How error handling should work. Re-export? A single error type for
  the whole crate?

This is a part of assert-rs#12
epage added a commit to epage/predicates-rs that referenced this issue Apr 2, 2018
@epage
feat(str): Regex predicate
bc04dec 
This is a short term API.  Different issues we'll need to consider when
evolving this include:
- Easy to create predicate
- The ability to customize the regex (e.g. case sensitivity, multi-line,
  ignoring whityespace).
  - It looks like the flags can be enabled with `(?flag)` inside the
    regex. Good enough?
- How error handling should work. Re-export? A single error type for
  the whole crate?

This is a part of assert-rs#12
epage added a commit to epage/predicates-rs that referenced this issue Apr 2, 2018
@epage
feat(str): Regex predicate
cc85f7c 
This is a short term API.  Different issues we'll need to consider when
evolving this include:
- Easy to create predicate
- The ability to customize the regex (e.g. case sensitivity, multi-line,
  ignoring whityespace).
  - It looks like the flags can be enabled with `(?flag)` inside the
    regex. Good enough?
- How error handling should work. Re-export? A single error type for
  the whole crate?

This is a part of assert-rs#12
epage added a commit to epage/predicates-rs that referenced this issue Apr 4, 2018
@epage
feat(str): Regex predicate
489c544 
This is a short term API.  Different issues we'll need to consider when
evolving this include:
- Easy to create predicate
- The ability to customize the regex (e.g. case sensitivity, multi-line,
  ignoring whityespace).
  - It looks like the flags can be enabled with `(?flag)` inside the
    regex. Good enough?
- How error handling should work. Re-export? A single error type for
  the whole crate?

This is a part of assert-rs#12
@epage
Copy link
Contributor Author

epage commented Apr 7, 2018

In assert-rs/assert_cli#85 someone was adding regex predicates to assert_cli. They had a desire for repetition matching. Something we should consider.

This was referenced Apr 7, 2018
Closed
Closed
@epage
Copy link
Contributor Author

epage commented Apr 16, 2018

#18 resolves the hamcrest part. Created a different issue for repetition.

@epage epage closed this as completed Apr 16, 2018
epage added a commit to epage/predicates-rs that referenced this issue Apr 26, 2024
@epage
Merge pull request assert-rs#12 from epage/renovate/actions-setup-pyt…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
c7805bc 
…hon-5.x

chore(deps): update actions/setup-python action to v5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improve the expected
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@epage