Fix ReaderThrowsResetExceptionOnInvalidBody (#1420)

Author: pakrym

test/Common.Tests/Utilities/TestConnections.cs

@@ -62,18 +62,15 @@ public void Dispose()
 
         public async Task Send(params string[] lines)
         {
-            var text = string.Join("\r\n", lines);
-            var writer = new StreamWriter(_stream, Encoding.GetEncoding("iso-8859-1"));
-            for (var index = 0; index < text.Length; index++)
+            var bytes = Encoding.ASCII.GetBytes(string.Join("\r\n", lines));
+
+            for (var index = 0; index < bytes.Length; index++)
             {
-                var ch = text[index];
-                writer.Write(ch);
-                await writer.FlushAsync().ConfigureAwait(false);
+                await _stream.WriteAsync(bytes, index, 1).ConfigureAwait(false);
+                await _stream.FlushAsync().ConfigureAwait(false);
                 // Re-add delay to help find socket input consumption bugs more consistently
                 //await Task.Delay(TimeSpan.FromMilliseconds(5));
             }
-            await writer.FlushAsync().ConfigureAwait(false);
-            await _stream.FlushAsync().ConfigureAwait(false);
         }
 
         public async Task<int> ReadCharAsync()

test/IIS.Tests/ClientDisconnectTests.cs

@@ -206,13 +206,15 @@ public async Task ReaderThrowsCancelledException()
         [ConditionalFact]
         public async Task ReaderThrowsResetExceptionOnInvalidBody()
         {
+            var requestStartedCompletionSource = CreateTaskCompletionSource();
             var requestCompletedCompletionSource = CreateTaskCompletionSource();
 
             Exception exception = null;
 
             var data = new byte[1024];
             using (var testServer = await TestServer.Create(async ctx =>
             {
+                requestStartedCompletionSource.SetResult(true);
                 try
                 {
                     await ctx.Request.Body.ReadAsync(data);
@@ -233,10 +235,19 @@ await connection.Send(
                         "Host: localhost",
                         "Connection: close",
                         "",
-                        "ZZZ",
                         "");
-                    await requestCompletedCompletionSource.Task.DefaultTimeout();
+
+                    await requestStartedCompletionSource.Task;
+                    await connection.Send(
+                        "ZZZZZZZZZZZZZ");
+
+                    await connection.Receive(
+                        "HTTP/1.1 400 Bad Request",
+                        ""
+                        );
+
                 }
+                await requestCompletedCompletionSource.Task.DefaultTimeout();
             }
 
             Assert.IsType<ConnectionResetException>(exception);