StopServer before asserting TestSink (#1416)

Author: pakrym

test/IISExpress.FunctionalTests/InProcess/StartupTests.cs

@@ -97,6 +97,7 @@ public async Task StartsWithDotnetOnThePath(string path)
             var deploymentResult = await DeployAsync(deploymentParameters);
             await deploymentResult.AssertStarts();
 
+            StopServer();
             // Verify that in this scenario where.exe was invoked only once by shim and request handler uses cached value
             Assert.Equal(1, TestSink.Writes.Count(w => w.Message.Contains("Invoking where.exe to find dotnet.exe")));
         }
@@ -143,7 +144,7 @@ public async Task DetectsOverriddenServer()
             Assert.Equal(HttpStatusCode.InternalServerError, response.StatusCode);
 
             StopServer();
-            
+
             EventLogHelpers.VerifyEventLogEvents(deploymentResult,
                 EventLogHelpers.InProcessFailedToStart(deploymentResult, "CLR worker thread exited prematurely"),
                 EventLogHelpers.InProcessThreadException(deploymentResult, ".*?Application is running inside IIS process but is not configured to use IIS server"));
@@ -154,7 +155,7 @@ public async Task LogsStartupExceptionExitError()
         {
             var deploymentParameters = _fixture.GetBaseDeploymentParameters(_fixture.InProcessTestSite, publish: true);
             deploymentParameters.TransformArguments((a, _) => $"{a} Throw");
-            
+
             var deploymentResult = await DeployAsync(deploymentParameters);
 
             var response = await deploymentResult.HttpClient.GetAsync("/");
@@ -166,7 +167,7 @@ public async Task LogsStartupExceptionExitError()
                 EventLogHelpers.InProcessFailedToStart(deploymentResult, "CLR worker thread exited prematurely"),
                 EventLogHelpers.InProcessThreadException(deploymentResult, ", exception code = '0xe0434352'"));
         }
-        
+
         [ConditionalFact]
         public async Task LogsUnexpectedThreadExitError()
         {
@@ -193,7 +194,7 @@ public async Task StartupTimeoutIsApplied()
                 WebConfigHelpers.AddOrModifyAspNetCoreSection("startupTimeLimit", "1"));
 
             var deploymentResult = await DeployAsync(deploymentParameters);
-            
+
             var response = await deploymentResult.HttpClient.GetAsync("/");
             Assert.Equal(HttpStatusCode.InternalServerError, response.StatusCode);
 
@@ -213,7 +214,7 @@ public async Task ShutdownTimeoutIsApplied()
                 WebConfigHelpers.AddOrModifyAspNetCoreSection("shutdownTimeLimit", "1"));
 
             var deploymentResult = await DeployAsync(deploymentParameters);
-            
+
             Assert.Equal("Hello World", await deploymentResult.HttpClient.GetStringAsync("/HelloWorld"));
 
             StopServer();

test/IISExpress.FunctionalTests/OutOfProcess/GlobalVersionTests.cs

@@ -184,6 +184,7 @@ private string GetANCMRequestHandlerPath(IISDeploymentResult deploymentResult, s
 
         private void AssertLoadedVersion(string version)
         {
+            StopServer();
             Assert.Contains(TestSink.Writes, context => context.Message.Contains(version + @"\aspnetcorev2_outofprocess.dll"));
         }