Skip to content

Commit 69e2af7

Browse files
Update for ASP.NET Core 3.0
Update the generator to produce providers for ASP.NET Core 3.0.
1 parent 7230a49 commit 69e2af7

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

generators/app/templates/AuthenticationHandler.cs

+6-6
Original file line numberDiff line numberDiff line change
@@ -8,14 +8,14 @@
88
using System.Net.Http.Headers;
99
using System.Security.Claims;
1010
using System.Text.Encodings.Web;
11+
using System.Text.Json;
1112
using System.Threading.Tasks;
1213
using JetBrains.Annotations;
1314
using Microsoft.AspNetCore.Authentication;
1415
using Microsoft.AspNetCore.Authentication.OAuth;
1516
using Microsoft.AspNetCore.WebUtilities;
1617
using Microsoft.Extensions.Logging;
1718
using Microsoft.Extensions.Options;
18-
using Newtonsoft.Json.Linq;
1919

2020
namespace AspNet.Security.OAuth.<%= name %>
2121
{
@@ -51,13 +51,13 @@ protected override async Task<AuthenticationTicket> CreateTicketAsync(
5151
// TODO Append any additional query string parameters required
5252
//endpoint = QueryHelpers.AddQueryString(endpoint, "token", tokens.AccessToken);
5353

54-
var request = new HttpRequestMessage(HttpMethod.Get, endpoint);
54+
using var request = new HttpRequestMessage(HttpMethod.Get, endpoint);
5555
request.Headers.Accept.Add(new MediaTypeWithQualityHeaderValue("application/json"));
5656

5757
// TODO Add any HTTP request headers required
5858
//request.Headers.Authorization = new AuthenticationHeaderValue("Bearer", tokens.AccessToken);
5959

60-
var response = await Backchannel.SendAsync(request, HttpCompletionOption.ResponseHeadersRead, Context.RequestAborted);
60+
using var response = await Backchannel.SendAsync(request, HttpCompletionOption.ResponseHeadersRead, Context.RequestAborted);
6161
if (!response.IsSuccessStatusCode)
6262
{
6363
Logger.LogError("An error occurred while retrieving the user profile: the remote server " +
@@ -69,11 +69,11 @@ protected override async Task<AuthenticationTicket> CreateTicketAsync(
6969
throw new HttpRequestException("An error occurred while retrieving the user profile from <%= name %>.");
7070
}
7171

72-
var payload = JObject.Parse(await response.Content.ReadAsStringAsync());
72+
using var payload = JsonDocument.Parse(await response.Content.ReadAsStringAsync());
7373

7474
var principal = new ClaimsPrincipal(identity);
75-
var context = new OAuthCreatingTicketContext(principal, properties, Context, Scheme, Options, Backchannel, tokens, payload);
76-
context.RunClaimActions(payload);
75+
var context = new OAuthCreatingTicketContext(principal, properties, Context, Scheme, Options, Backchannel, tokens, payload.RootElement);
76+
context.RunClaimActions();
7777

7878
await Options.Events.CreatingTicket(context);
7979
return new AuthenticationTicket(context.Principal, context.Properties, Scheme.Name);

generators/app/templates/Project.csproj

+2-2
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
<Import Project="..\..\build\packages.props" />
44

55
<PropertyGroup>
6-
<TargetFrameworks>netstandard2.0</TargetFrameworks>
6+
<TargetFramework>netcoreapp3.0</TargetFramework>
77
</PropertyGroup>
88

99
<PropertyGroup>
@@ -13,8 +13,8 @@
1313
</PropertyGroup>
1414

1515
<ItemGroup>
16+
<FrameworkReference Include="Microsoft.AspNetCore.App" />
1617
<PackageReference Include="JetBrains.Annotations" Version="$(JetBrainsVersion)" PrivateAssets="All" />
17-
<PackageReference Include="Microsoft.AspNetCore.Authentication.OAuth" Version="$(AspNetCoreVersion)" />
1818
</ItemGroup>
1919

2020
</Project>

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "generator-aspnet-oauth",
3-
"version": "2.0.0",
3+
"version": "3.0.0",
44
"description": "Yeoman generator for OAuth Providers for ASP.NET Core",
55
"license": "MIT",
66
"main": "app/index.js",

0 commit comments

Comments
 (0)