You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
fix(coverage): produce combined coverage report (#520)
Bazel is not producing combined coverage report for targets that don't
define the `_lcov_merger` attribute, the `collect_coverage.sh` script
just exits silently in this case:
https://github.com/bazelbuild/bazel/blob/fde4b67009d377a3543a3dc8481147307bd37d36/tools/test/collect_coverage.sh#L186-L194
Since `rules_python` defines this attribute both for `py_binary` and
`py_test`, we're mirroring this behavior by modifying `py_base.attrs`.
Tested by applying the patch and verifying that
`bazel-out/_coverage/_coverage_report.dat` is not empty after running
`bazel coverage --combined_report=lcov [target]`.
0 commit comments