You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
fix(venv_link): Restore original venv name mangling (#589)
Reported by @jimmyt857 in testing of v1.6.0-rc0
Previously running the `examples/py_binary:py_binary.venv` target would
create a link
`$BUILD_WORKING_DIRECTORY/.examples+py_binary+py_binary.venv`. This
behavior regressed in 1.5.0 and the link became simply
`$BUILD_WORKING_DIRECTORY/.py_binary.venv`.
Restore the original behavior.
---
### Changes are visible to end-users: no
- Searched for relevant documentation and updated as needed: no
- Breaking change (forces users to change their own code or config): no
- Suggested release notes appear below: no
### Test plan
- [x] Manual testing
```shellsession
❯ bazel run //examples/py_binary:py_binary.venv
INFO: Analyzed target //examples/py_binary:py_binary.venv (0 packages loaded, 0 targets configured).
INFO: Found 1 target...
Target //examples/py_binary:py_binary.venv up-to-date:
bazel-bin/examples/py_binary/py_binary.venv
INFO: Elapsed time: 0.815s, Critical Path: 0.05s
INFO: 2 processes: 1 internal, 1 darwin-sandbox.
INFO: Build completed successfully, 2 total actions
INFO: Running command line: bazel-bin/examples/py_binary/py_binary.venv
usage: link [options]
Helper to create a symlink to a virtualenv in the source tree.
optional arguments:
-h, --help show this help message and exit
--dest DEST Dir to link the virtualenv into. Default is $BUILD_WORKING_DIRECTORY. (default: /Users/arrdem/Documents/work/aspect/rules_py)
--name NAME Name to link the virtualenv as. (default: .examples+py_binary+py_binary.venv)
Linking: /private/var/tmp/_bazel_arrdem/93bfea6cdc1153cc29a75400cd38823a/execroot/aspect_rules_py/bazel-out/darwin_arm64-fastbuild/bin/examples/py_binary/.py_binary.venv -> /Users/arrdem/Documents/work/aspect/rules_py/.examples+py_binary+py_binary.venv
Link is up to date!
To configure the virtualenv in your IDE, configure an interpreter with the homedir
/Users/arrdem/Documents/work/aspect/rules_py/.examples+py_binary+py_binary.venv
To activate the virtualenv in your shell run
source /Users/arrdem/Documents/work/aspect/rules_py/.examples+py_binary+py_binary.venv/bin/activate
```
0 commit comments